This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Evergreen ILS". The branch, rel_3_13 has been updated via fd7e175ec053058ec0e24adbd7f3aec8f2dfe197 (commit) from f91846eb2e21aa91a263d6c4beb1c47576520f9c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fd7e175ec053058ec0e24adbd7f3aec8f2dfe197 Author: Stephanie Leary <stephanie.leary@equinoxoli.org> Date: Tue Mar 11 15:03:40 2025 +0000 LP2101886 MARC editor: allow right arrow in inputs In the MARC rich editor, the right arrow key is used to move from a selected subfield group to the first input in the group (the subfield code). This event listener was not specific enough, so that people using the right arrow key within a text input to move the cursor would unexpectedly find their focus moved backwards to the subfield code of the field data they were trying to edit. We now check whether the event target is an input or textarea field before moving focus. Release-note: Right arrow in MARC subfield data no longer moves focus Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Llewellyn Marshall <llewellyn.marshall@dncr.nc.gov> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> diff --git a/Open-ILS/src/eg2/src/app/staff/share/marc-edit/rich-editor.component.ts b/Open-ILS/src/eg2/src/app/staff/share/marc-edit/rich-editor.component.ts index e0aad070ba..3dbdca5839 100644 --- a/Open-ILS/src/eg2/src/app/staff/share/marc-edit/rich-editor.component.ts +++ b/Open-ILS/src/eg2/src/app/staff/share/marc-edit/rich-editor.component.ts @@ -210,6 +210,13 @@ export class MarcRichEditorComponent implements OnInit { onKeyDown(evt: KeyboardEvent, field: MarcField, subfield?: MarcSubfield) { switch (evt.key) { case 'ArrowRight': + // console.debug("ArrowRight: ", evt, field, subfield); + let el = evt.target as HTMLElement; + // do nothing if we are in a text input + if (el.nodeName && (el.nodeName.toLowerCase() === 'input' || el.nodeName.toLowerCase() === 'textarea')) { + return; + } + // otherwise, move focus from the group to its first input (the subfield code) evt.preventDefault(); evt.stopPropagation(); this.context.focusSubfield(field, subfield[2], false); ----------------------------------------------------------------------- Summary of changes: .../src/eg2/src/app/staff/share/marc-edit/rich-editor.component.ts | 7 +++++++ 1 file changed, 7 insertions(+) hooks/post-receive -- Evergreen ILS