This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Evergreen ILS". The branch, main has been updated via 3df0ccdcd7322af0a798cedf8d31839da99e4f69 (commit) from 4c67fc697bc54e1f408a565c252523d69d4404c0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3df0ccdcd7322af0a798cedf8d31839da99e4f69 Author: Terran McCanna <tmccanna@georgialibraries.org> Date: Thu Mar 13 10:36:30 2025 -0400 LP2102217 Holdings View Sublibrary Sort Order Org node children are currently sorted by org node children first followed by call number node children. This changes the sort order to place call number children first, followed by org node children to reduce visual confusion. Release-note: Changes holdings view sort order to push sublibrary nodes below call number nodes. Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Lindsay Stratton <lstratton@wlsmail.org> diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/record/holdings.component.ts b/Open-ILS/src/eg2/src/app/staff/catalog/record/holdings.component.ts index ab66e2ddb8..e1e70861e7 100644 --- a/Open-ILS/src/eg2/src/app/staff/catalog/record/holdings.component.ts +++ b/Open-ILS/src/eg2/src/app/staff/catalog/record/holdings.component.ts @@ -407,18 +407,26 @@ export class HoldingsMaintenanceComponent implements OnInit { traverseOrg(this.holdingsTree.root); } - // Org node children are sorted with any child org nodes pushed to the - // front, followed by the call number nodes sorted alphabetcially by label. + // Org node children are sorted by call number nodes attached to the org unit first, + // followed by child org unit nodes. Peers are sorted alphabetically by label. + // Example: If SYS2-BR3 has holdings but also has a bookmobile SYS2-BR3-BM1 + // that has its own holdings then the hierarchy should display as: + // SYS2 + // - BR3 + // - - MR248 (BR3's holdings) + // - - BM1 + // - - - MR248 (BM1's holdings) + sortOrgNodeChildren(node: HoldingsTreeNode) { node.children = node.children.sort((a, b) => { if (a.nodeType === 'org') { if (b.nodeType === 'org') { return a.target.shortname() < b.target.shortname() ? -1 : 1; } else { - return -1; + return 1; } } else if (b.nodeType === 'org') { - return 1; + return -1; } else { // TODO: should this use label sortkey instead of // the compiled call number label? ----------------------------------------------------------------------- Summary of changes: .../src/app/staff/catalog/record/holdings.component.ts | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) hooks/post-receive -- Evergreen ILS