This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Evergreen ILS". The branch, main has been updated via ff4a622bdb3ad553f2a02abf8d8b971edb4e1dab (commit) from 9c23b870f2360b6814ca1751c20a64850fbf4993 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ff4a622bdb3ad553f2a02abf8d8b971edb4e1dab Author: Jane Sandberg <sandbergja@gmail.com> Date: Mon Mar 31 13:15:14 2025 -0700 Follow-up: fix ng lint Several lint issues have crept into main from various new features. This commit includes automated fixes (npx ng lint --fix) and ignores one lint error that cannot be fixed automatically Signed-off-by: Jane Sandberg <sandbergja@gmail.com> diff --git a/Open-ILS/src/eg2/src/app/share/toast/toast.component.ts b/Open-ILS/src/eg2/src/app/share/toast/toast.component.ts index 8e01cd0b42..341340724b 100644 --- a/Open-ILS/src/eg2/src/app/share/toast/toast.component.ts +++ b/Open-ILS/src/eg2/src/app/share/toast/toast.component.ts @@ -36,7 +36,7 @@ export class ToastComponent implements OnInit { show(msg: ToastMessage) { this.messages.push(msg); console.info($localize`${new Date().toLocaleTimeString()} - ${msg.text}`); - + this.timeout = setTimeout( () => this.messages.shift(), this.duration diff --git a/Open-ILS/src/eg2/src/app/staff/cat/volcopy/volcopy.service.ts b/Open-ILS/src/eg2/src/app/staff/cat/volcopy/volcopy.service.ts index 25474ae1d6..71c320c6ac 100644 --- a/Open-ILS/src/eg2/src/app/staff/cat/volcopy/volcopy.service.ts +++ b/Open-ILS/src/eg2/src/app/staff/cat/volcopy/volcopy.service.ts @@ -604,8 +604,7 @@ export class VolCopyService implements OnDestroy { // convert actual booleans to 't' and 'f' Object.keys(data).forEach(key => { if (this.idl.classes.acp.field_map[key]?.datatype === 'bool') { - if (data[key] === true) { data[key] = 't'; } - else if (data[key] === false) { data[key] = 'f'; } + if (data[key] === true) { data[key] = 't'; } else if (data[key] === false) { data[key] = 'f'; } } }); @@ -616,8 +615,7 @@ export class VolCopyService implements OnDestroy { data[thing].forEach(thingElement => { Object.keys(thingElement).forEach(key => { if (this.idl.classes[ant[thing]].field_map[key].datatype === 'bool') { - if (thingElement[key] === true) { thingElement[key] = 't'; } - else if (thingElement[key] === false) { thingElement[key] = 'f'; } + if (thingElement[key] === true) { thingElement[key] = 't'; } else if (thingElement[key] === false) { thingElement[key] = 'f'; } } }); }); diff --git a/Open-ILS/src/eg2/src/app/staff/nav.component.ts b/Open-ILS/src/eg2/src/app/staff/nav.component.ts index 173f942dd0..546235a7f7 100644 --- a/Open-ILS/src/eg2/src/app/staff/nav.component.ts +++ b/Open-ILS/src/eg2/src/app/staff/nav.component.ts @@ -188,8 +188,7 @@ export class StaffNavComponent implements OnInit, OnDestroy { const staffContainer = document.getElementById('staff-content-container'); if (disable_links_newtabs) { staffContainer.classList.add('user-pref-no-new-tabs'); - } - else { + } else { staffContainer.classList.remove('user-pref-no-new-tabs'); } } diff --git a/Open-ILS/src/eg2/src/app/staff/share/holdings/copy-things-dialog.component.ts b/Open-ILS/src/eg2/src/app/staff/share/holdings/copy-things-dialog.component.ts index adfc1c110b..947a4606b6 100644 --- a/Open-ILS/src/eg2/src/app/staff/share/holdings/copy-things-dialog.component.ts +++ b/Open-ILS/src/eg2/src/app/staff/share/holdings/copy-things-dialog.component.ts @@ -198,7 +198,7 @@ export abstract class CopyThingsDialogComponent< */ protected async initializeCopies(): Promise<void> { /* - console.debug(`CopyThingsDialog(${this.thingType}): initializeCopies(), this.copies, + console.debug(`CopyThingsDialog(${this.thingType}): initializeCopies(), this.copies, this.copyIds`, this.copies, this.copyIds); /** */ if (!this.copies) { @@ -215,7 +215,7 @@ export abstract class CopyThingsDialogComponent< }); /* - console.debug(`CopyThingsDialog(${this.thingType}): initializeCopies(); + console.debug(`CopyThingsDialog(${this.thingType}): initializeCopies(); this.inPlaceCreateMode, this.inBatch()`, this.inPlaceCreateMode, this.inBatch()); /** */ @@ -226,7 +226,7 @@ export abstract class CopyThingsDialogComponent< // This is also mucking with our pending changes when the dialog is // reinvoked before save; hrmm. clones/new-instances vs references /* - console.debug(`CopyThingsDialog(${this.thingType}): initializeCopies(); + console.debug(`CopyThingsDialog(${this.thingType}): initializeCopies(); calling this.getThings`); /** */ await this.getThings(); @@ -234,7 +234,7 @@ export abstract class CopyThingsDialogComponent< // Process batch things if needed if (this.inBatch()) { /* - console.debug(`CopyThingsDialog(${this.thingType}): initializeCopies(); + console.debug(`CopyThingsDialog(${this.thingType}): initializeCopies(); calling this.processCommonThings`); /** */ await this.processCommonThings(); @@ -352,16 +352,16 @@ export abstract class CopyThingsDialogComponent< /* console.debug(`CopyThingsDialog(${this.thingType}): removeThing: things`, this.idl.clone(things)); - console.debug(`CopyThingsDialog(${this.thingType}): removeThing: + console.debug(`CopyThingsDialog(${this.thingType}): removeThing: incoming this.newThings`, this.newThings.length, this.idl.clone(this.newThings)); - console.debug(`CopyThingsDialog(${this.thingType}): removeThing: + console.debug(`CopyThingsDialog(${this.thingType}): removeThing: incoming this.changedThings`, this.changedThings.length, this.idl.clone(this.changedThings)); - console.debug(`CopyThingsDialog(${this.thingType}): removeThing: + console.debug(`CopyThingsDialog(${this.thingType}): removeThing: incoming this.deletedThings`, this.deletedThings.length, this.idl.clone(this.deletedThings)); /** */ things.forEach(thing => { /* - console.debug(`CopyThingsDialog(${this.thingType}): removeThing: + console.debug(`CopyThingsDialog(${this.thingType}): removeThing: considering thing with id, isnew, ischanged, isdeleted`, this.idl.clone(thing), thing?.id(), thing?.isnew(), thing?.ischanged(), thing?.isdeleted()); /** */ diff --git a/Open-ILS/src/eg2/src/app/staff/share/holdings/tag-map-list.component.ts b/Open-ILS/src/eg2/src/app/staff/share/holdings/tag-map-list.component.ts index 2e3ed53f39..9a65609280 100644 --- a/Open-ILS/src/eg2/src/app/staff/share/holdings/tag-map-list.component.ts +++ b/Open-ILS/src/eg2/src/app/staff/share/holdings/tag-map-list.component.ts @@ -55,9 +55,10 @@ export class TagMapListComponent implements OnInit { this.trickery(this); } + // eslint-disable-next-line rxjs/no-async-subscribe this.broadcaster.listen('eg.acpt_updated').subscribe(async (data) => { // console.debug('TagMapListComponent listener received',data); - if (typeof data.result === 'string' || typeof data.result == 'number') { + if (typeof data.result === 'string' || typeof data.result === 'number') { const flesh = { flesh: 1, flesh_fields: { diff --git a/Open-ILS/src/eg2/src/app/staff/share/marc-edit/editable-content.component.ts b/Open-ILS/src/eg2/src/app/staff/share/marc-edit/editable-content.component.ts index d6ebca0dbb..1e04fba77a 100644 --- a/Open-ILS/src/eg2/src/app/staff/share/marc-edit/editable-content.component.ts +++ b/Open-ILS/src/eg2/src/app/staff/share/marc-edit/editable-content.component.ts @@ -153,7 +153,7 @@ implements OnInit, AfterViewInit, OnDestroy { } selectText(req?: FieldFocusRequest) { - if (this.field && typeof this.field == 'object') { + if (this.field && typeof this.field === 'object') { this.field.hasFocus = true; this.field.isDraggable = false; } ----------------------------------------------------------------------- Summary of changes: Open-ILS/src/eg2/src/app/share/toast/toast.component.ts | 2 +- .../src/eg2/src/app/staff/cat/volcopy/volcopy.service.ts | 6 ++---- Open-ILS/src/eg2/src/app/staff/nav.component.ts | 3 +-- .../staff/share/holdings/copy-things-dialog.component.ts | 16 ++++++++-------- .../app/staff/share/holdings/tag-map-list.component.ts | 3 ++- .../staff/share/marc-edit/editable-content.component.ts | 2 +- 6 files changed, 15 insertions(+), 17 deletions(-) hooks/post-receive -- Evergreen ILS