This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Evergreen ILS". The branch, main has been updated via 2cd643df8a207eff8f232a97efa37471b9e65da8 (commit) via 6de17f25d8da669b501bcd511602fe8ba0803115 (commit) via af69e68de814b8872db33a6ec55cdc02463ec765 (commit) from ee6c53dfee3f7f50d5bf3b601a85ea042e582e15 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2cd643df8a207eff8f232a97efa37471b9e65da8 Author: Michele Morgan <mmorgan@noblenet.org> Date: Fri Mar 21 16:06:22 2025 -0400 LP1815950: Release Notes Signed-off-by: Michele Morgan <mmorgan@noblenet.org> diff --git a/docs/RELEASE_NOTES_NEXT/Circulation/lp1815950_patron_reg_field_visibility b/docs/RELEASE_NOTES_NEXT/Circulation/lp1815950_patron_reg_field_visibility new file mode 100644 index 0000000000..88a03f01fd --- /dev/null +++ b/docs/RELEASE_NOTES_NEXT/Circulation/lp1815950_patron_reg_field_visibility @@ -0,0 +1,12 @@ +== Visibilty of Fields in Patron Registration/Edit == + +Enhances the ability to control display of Required, Suggested and All fields on the Patron Registration/Edit Screen. + +Given a field with three library settings, .show, .suggest, .require: + +.show = FALSE hides the field +.show = TRUE displays the field in All, Suggested, Required (field is not required) +.suggest = TRUE displays the field in All, Suggested +.require = TRUE displays the field in All, Suggested, Required (field is required) + +.show, .suggest, .require UNSET displays the field in All, but not Suggested or Required commit 6de17f25d8da669b501bcd511602fe8ba0803115 Author: Jason Stephenson <jason@sigio.com> Date: Thu Feb 13 13:57:07 2025 -0500 LP1815950: Do not hide database-required patron fields This commit adds a check for default visibility of patron registration/edit fields before hiding a field when the show setting is false. This is done to prevent database-required fields from being hidden and blocking the saving of form data. The upshot is that all database-required fields should have a default visibitly of 3, for "required." An audit of the default visibility array has NOT been done. Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> diff --git a/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js b/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js index aefc249d4f..94c655de7d 100644 --- a/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js +++ b/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js @@ -1682,7 +1682,11 @@ function($scope , $routeParams , $q , $uibModal , $window , egCore , } else if ($scope.org_settings[sho_set] === false){ // hide the field if the 'show' setting is explicitly false (not undefined) - field_visibility[field_key] = -1; + if (default_field_visibility[field_key] === undefined + || default_field_visibility[field_key] < 3) { + // Only hide if not a database-required field + field_visibility[field_key] = -1; + } } } commit af69e68de814b8872db33a6ec55cdc02463ec765 Author: a. bellenir <abelleni@grpl.org> Date: Thu Feb 14 16:16:53 2019 -0500 LP1815950: Hide patron registration/edit fields When org unit settings like au.prefix.show are set to true, the field is made visible when the user shows "Suggested" or "Required" fields. Setting au.prefix.show to false had no effect. This change will hide the field entirely (even from "All Fields") if the relevant '.show' setting is explicitly false (not just undefined) by setting a negative value in field_visibility[field_key]. Signed-off-by: a. bellenir <abelleni@grpl.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> diff --git a/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js b/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js index 47da02d49b..aefc249d4f 100644 --- a/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js +++ b/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js @@ -1679,6 +1679,10 @@ function($scope , $routeParams , $q , $uibModal , $window , egCore , } else if ($scope.org_settings[sug_set]) { field_visibility[field_key] = 1; + + } else if ($scope.org_settings[sho_set] === false){ + // hide the field if the 'show' setting is explicitly false (not undefined) + field_visibility[field_key] = -1; } } ----------------------------------------------------------------------- Summary of changes: Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js | 8 ++++++++ .../Circulation/lp1815950_patron_reg_field_visibility | 12 ++++++++++++ 2 files changed, 20 insertions(+) create mode 100644 docs/RELEASE_NOTES_NEXT/Circulation/lp1815950_patron_reg_field_visibility hooks/post-receive -- Evergreen ILS