This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Evergreen ILS". The branch, main has been updated via 4224db38675a9ab80471af2c67c4f9bdad641c50 (commit) from 83e22d958936c9f3171c2379ab4ed27b9077e0f6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4224db38675a9ab80471af2c67c4f9bdad641c50 Author: Jane Sandberg <js7389@princeton.edu> Date: Tue Jun 24 07:24:03 2025 -0700 lp2096916: follow-up: ng lint fixes Signed-off-by: Jane Sandberg <js7389@princeton.edu> diff --git a/Open-ILS/src/eg2/src/app/staff/cat/volcopy/volcopy.component.html b/Open-ILS/src/eg2/src/app/staff/cat/volcopy/volcopy.component.html index 3bad0d45c4..a7df3c928f 100644 --- a/Open-ILS/src/eg2/src/app/staff/cat/volcopy/volcopy.component.html +++ b/Open-ILS/src/eg2/src/app/staff/cat/volcopy/volcopy.component.html @@ -102,7 +102,7 @@ <p *ngIf="changesPendingForStatusBar" class="col-12 alert alert-warning text-center" i18n>Changes Pending</p> <p *ngIf="barcodeNeeded()" class="col-12 alert alert-warning text-center" i18n>At least one barcoded item needed for current changes.</p> <p *ngIf="partNeeded()" class="col-12 alert alert-warning text-center"> - <ng-container *ngIf="missingPartsCount == 1" i18n>1 item requires a part.</ng-container> + <ng-container *ngIf="missingPartsCount === 1" i18n>1 item requires a part.</ng-container> <ng-container *ngIf="missingPartsCount > 1" i18n>{{missingPartsCount}} items require a part.</ng-container> </p> </div> diff --git a/Open-ILS/src/eg2/src/app/staff/cat/volcopy/volcopy.component.ts b/Open-ILS/src/eg2/src/app/staff/cat/volcopy/volcopy.component.ts index 8cea09566a..ee1e846f9d 100644 --- a/Open-ILS/src/eg2/src/app/staff/cat/volcopy/volcopy.component.ts +++ b/Open-ILS/src/eg2/src/app/staff/cat/volcopy/volcopy.component.ts @@ -82,8 +82,8 @@ export class VolCopyComponent implements OnInit { // For every copy in the context, whether or not the copy needs to require a part itemRequirePartsMap : {[key: number]: boolean} = {}; - missingPartsCount: number = 0; - + missingPartsCount = 0; + not_allowed_vols = []; @ViewChild('pendingChangesDialog', {static: false}) @@ -819,27 +819,27 @@ export class VolCopyComponent implements OnInit { const settingEnabled = this.orgRequiresParts[org]; const recordHasParts = this.volcopy.bibParts[record] && this.volcopy.bibParts[record].length > 0; - const copyStatusHoldable = this.volcopy.copyStatuses[copyNode.target.status()].holdable() == "t" - const copyHoldableFlag = copyNode.target.holdable() == "t"; - const copyShelvingLocationHoldable = copyNode.target.location().holdable() == "t"; + const copyStatusHoldable = this.volcopy.copyStatuses[copyNode.target.status()].holdable() === 't'; + const copyHoldableFlag = copyNode.target.holdable() === 't'; + const copyShelvingLocationHoldable = copyNode.target.location().holdable() === 't'; const copyIsHoldable = copyStatusHoldable && copyHoldableFlag && copyShelvingLocationHoldable; const copyRequiresPart = settingEnabled && recordHasParts && copyIsHoldable; // Only update when changing in case that matters for performance. (binding propagation) - if (this.itemRequirePartsMap[copy.id()] != copyRequiresPart) { + if (this.itemRequirePartsMap[copy.id()] !== copyRequiresPart) { this.itemRequirePartsMap[copy.id()] = copyRequiresPart; } - + return copyRequiresPart; - + } partNeeded() : boolean { let needPart = false; let missingCount = 0; for (const copy of this.context.copyList()) { - let copyRequiresPart = this.copyRequiresPart(copy); + const copyRequiresPart = this.copyRequiresPart(copy); const copyHasParts = Boolean(copy.parts()?.length); const copyMissingPart = copyRequiresPart && !copyHasParts; @@ -851,7 +851,7 @@ export class VolCopyComponent implements OnInit { } // Silly conditional assignment to not overwhelm Angular change detection - if (missingCount != this.missingPartsCount) { + if (missingCount !== this.missingPartsCount) { this.missingPartsCount = missingCount; } return needPart; ----------------------------------------------------------------------- Summary of changes: .../src/app/staff/cat/volcopy/volcopy.component.html | 2 +- .../src/app/staff/cat/volcopy/volcopy.component.ts | 20 ++++++++++---------- 2 files changed, 11 insertions(+), 11 deletions(-) hooks/post-receive -- Evergreen ILS