This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Evergreen ILS". The branch, rel_3_13 has been updated via 44c3dc0482fdf4d103d798ac9f2e7b8bd2342adb (commit) from 7788751a819d94850524977512389381d0df57b3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 44c3dc0482fdf4d103d798ac9f2e7b8bd2342adb Author: Josh Stompro <stomproj@larl.org> Date: Wed Jul 24 14:08:57 2024 -0500 LP#2073896 - Angular Catalog Place Holds Ignore Empty User Setting When placing a hold in the Angular Staff Catalog, the Phone Number for Notify by Phone was correctly grabbing the Day Phone as a default value, but was then having a blank user setting for 'opac.default_phone' = '""' clear out that value, preventing the day phone from being used. Blank user settings sometimes get set to '""' when unset. The code that handles populating the hold notification preferences was looking for null or '' values, but wasn't looking for '""'. Release-note: Fixes blank user setting handling in Angular staff catalog place holds. Testing Notes: Before fix is applied. Setup: 1. Choose a patron to test with. 2. Enter a Daytime Phone number if it doesn't exists. 3. Enter a Default Phone Number 4. Uncheck the notice preferences just for simplicity so saving the record is easier. 5. Save the Record. 6. Remove the Default Phone Number and save again. This ensures the user setting exists as a blank value. Test: 1. Find a title in the angular staff catalog and place a hold. 2. Enter the patron's barcode. 3. Note that nothing shows up in the phone number field. After Fix: 1. Use the same setup as above. 2. Find a title in the angular staff catalog and place a hold. 3. Enter the patron's barcode. 4. Note that now the daytime phone number shows up in the phone field. 5. Check the Notify by phone box, and place the hold using the daytime phone number as the phone notify number. Signed-off-by: Josh Stompro <stomproj@larl.org> Signed-off-by: Lindsay Stratton <lstratton@wlsmail.org> Signed-off-by: Gina Monti <gmonti@biblio.org> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org> diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.ts b/Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.ts index 21c203d7bc..ffc95004ee 100644 --- a/Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.ts +++ b/Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.ts @@ -483,7 +483,7 @@ export class HoldComponent implements OnInit { const name = setting.name(); let value = setting.value(); - if (value === '' || value === null) { return; } + if (value === '' || value === null || value === '""') { return; } // When fleshing 'settings' on the actor.usr object, // we're grabbing the raw JSON values. ----------------------------------------------------------------------- Summary of changes: Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- Evergreen ILS