[Evergreen-acq] Fwd: [Bug 2084096] Re: Line items cannot be canceled using a true cancel reason

[Jennifer Pringle]

That is great news!

Thank you Mary, Ian, and the New Devs group for finding and fixing this bug!

Jennifer

--
Jennifer Pringle (she/her)
Co-op Support - Training Lead
BC Libraries Cooperative
Toll-free: 1-888-848-9250
Email:jennifer.pringle at bc.libraries.coop
Website: http://bc.libraries.coop

Gratefully acknowledging that I live and work in the unceded Traditional Territory of the St'at'yemc Nations.

From: Evergreen-acq <evergreen-acq-bounces at list.evergreen-ils.org> On Behalf Of Tiffany Little via Evergreen-acq
Sent: October 21, 2024 6:02 AM
To: Evergreen ACQ Listserv <evergreen-acq at list.evergreen-ils.org>
Cc: Tiffany Little <tlittle at georgialibraries.org>
Subject: [Evergreen-acq] Fwd: [Bug 2084096] Re: Line items cannot be canceled using a true cancel reason

Good morning,

Good news! The bug that Mary brought up at our last meeting--where line items couldn't be true canceled--now has a fix! Thank you to Ian from Bibliomation for the fix, and to the New Devs group for reviewing and creating unit tests for the problem.

This is now Fix Committed for 3_13 and above (thanks Jane!).

Tiffany


[Image removed by sender. logo with link to Georgia Public Library Service website]<https://georgialibraries.org/>

Tiffany Little

PINES Bibliographic Projects Manager

________________________________

Georgia Public Library Service

2872 Woodcock Blvd, Suite 250 | Atlanta, GA 30341

(404) 235-7161 | tlittle at georgialibraries.org<mailto:tlittle at georgialibraries.org>

[Image removed by sender. logo with link to Georgia Public Library Service Facebook page]<https://www.facebook.com/georgialibraries>[Image removed by sender. logo with link to Georgia Public Library Service Instagram page]<https://www.instagram.com/georgialibraries/>[Image removed by sender. logo with link to Georgia Public Library Service LinkedIn page]<https://www.linkedin.com/company/georgia-public-library-service/>[Image removed by sender. logo with link to Georgia Public Library Service Threads page]<https://www.threads.net/@georgialibraries>

Join our email list<http://georgialibraries.org/subscription> for stories of Georgia libraries making an impact in our communities.

---------- Forwarded message ---------
From: Jane Sandberg <2084096 at bugs.launchpad.net<mailto:2084096 at bugs.launchpad.net>>
Date: Thu, Oct 17, 2024 at 12:05 PM
Subject: [Bug 2084096] Re: Line items cannot be canceled using a true cancel reason
To: <tlittle at georgialibraries.org<mailto:tlittle at georgialibraries.org>>


Fix confirmed in yesterday's newdevs meeting.  I've pushed this to
rel_3_13 and above.  Thanks, Ian, and all collaborators at yesterday's
meeting!

** Changed in: evergreen
     Assignee: Ian Skelskey (ianskelskey) => (unassigned)

** Changed in: evergreen
       Status: Confirmed => Fix Committed

** Also affects: evergreen/3.13
   Importance: Undecided
       Status: New

** Changed in: evergreen
    Milestone: None => 3.14.1

** Changed in: evergreen
    Milestone: 3.14.1 => 3.14.0

** Changed in: evergreen/3.13
    Milestone: None => 3.13.5

** Changed in: evergreen/3.13
   Importance: Undecided => High

** Changed in: evergreen/3.13
       Status: New => Fix Committed

** Tags added: pullrequest signedoff

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/2084096

Title:
  Line items cannot be canceled using a true cancel reason

Status in Evergreen:
  Fix Committed
Status in Evergreen 3.13 series:
  Fix Committed

Bug description:
  Tested on a 3.14-beta and also seen on a 3.13 test server.

  Trying to cancel a line item with associated catalog items (eg copy
  ids) fails silently. There are two console error produced:

  open-ils.acq.lineitem.cancel.batch failed! stat=500 msg= *** Call to [open-ils.acq.lineitem.cancel.batch] failed for session [0.363031297134109861728503116536], thread trace [0]:
  Can't call method "owning_lib" on an undefined value at /usr/local/share/perl/5.34.0/OpenILS/Application/Cat/AssetCommon.pm line 846.


  ERROR Error: Uncaught (in promise): open-ils.acq.lineitem.cancel.batch failed! stat=500 msg= *** Call to [open-ils.acq.lineitem.cancel.batch] failed for session [0.363031297134109861728503116536], thread trace [0]:
  Can't call method "owning_lib" on an undefined value at /usr/local/share/perl/5.34.0/OpenILS/Application/Cat/AssetCommon.pm line 846.


      at resolvePromise (zone.js:1214:31)
      at resolvePromise (zone.js:1168:17)
      at zone.js:1281:17
      at _ZoneDelegate.invokeTask (zone.js:409:31)
      at core.mjs:23896:55
      at AsyncStackTaggingZoneSpec.onInvokeTask (core.mjs:23896:36)
      at _ZoneDelegate.invokeTask (zone.js:408:60)
      at Object.onInvokeTask (core.mjs:24197:33)
      at _ZoneDelegate.invokeTask (zone.js:408:60)
      at Zone.runTask (zone.js:178:47)


  To reproduce:
  1. Create a purchase order.
  2. Add a line item with item, estimated price, owning lib, shelving location and fund.
  3. Activate purchase order. Do *not* choose "Activate without loading items.
  4. Cancel the line item using a cancel reason that does not keep fund debits. (Cancel reason should start with "Canceled".)
  5. You will see the console error appear, but the page doesn't refresh and no error is given.

  This breaks a fundamental piece of Acquisitions, and is considered a
  acq blocker for 3.13 and 3.14 by the AIG.

To manage notifications about this bug go to:
https://bugs.launchpad.net/evergreen/+bug/2084096/+subscriptions
This message originated from outside the M365 organisation. Please be careful with links, and don't trust messages you don't recognise.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://list.evergreen-ils.org/pipermail/evergreen-acq/attachments/20241021/0c49dc18/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ~WRD0000.jpg
Type: image/jpeg
Size: 823 bytes
Desc: ~WRD0000.jpg
URL: <http://list.evergreen-ils.org/pipermail/evergreen-acq/attachments/20241021/0c49dc18/attachment-0001.jpg>