[open-ils-commits] [GIT] Evergreen ILS branch master updated. 7d8e0cab70128e271f7cfcc321cf67c6b1027aa2

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  7d8e0cab70128e271f7cfcc321cf67c6b1027aa2 (commit)
      from  693ed63d2f3f92ef1be6d474c6d5b732e3b65912 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 7d8e0cab70128e271f7cfcc321cf67c6b1027aa2
Author: Dan Scott <dscott at laurentian.ca>
Date:   Tue Jun 18 12:17:40 2013 -0400

    Prevent uninit var warnings in Search/Biblio.pm
    
    The logger messages in Search/Biblio.pm throw _many_ uninitialized
    variable warnings. With a little care, we can prevent those warnings and
    return our attention to more important log messages.
    
    Signed-off-by: Dan Scott <dscott at laurentian.ca>
    Signed-off-by: Ben Shum <bshum at biblio.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm
index 71a8563..c8b290d 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm
@@ -1384,7 +1384,10 @@ sub staged_search {
             if $page == 0;
 
         $logger->debug("staged search: located $current_count, with estimated hits=".
-            $summary->{estimated_hit_count}." : visible=".$summary->{visible}.", checked=".$summary->{checked});
+            ($summary->{estimated_hit_count} || "none") .
+            " : visible=" . ($summary->{visible} || "none") . ", checked=" .
+            ($summary->{checked} || "none")
+        );
 
         if (defined($summary->{estimated_hit_count})) {
             foreach (qw/ checked visible excluded deleted /) {
@@ -1618,7 +1621,9 @@ sub cache_staged_search_page {
     };
 
     $logger->info("staged search: cached with key=$key, superpage=$page, estimated=".
-        $summary->{estimated_hit_count}.", visible=".$summary->{visible});
+        ($summary->{estimated_hit_count} || "none") .
+        ", visible=" . ($summary->{visible} || "none")
+    );
 
     $cache->put_cache($key, $data, $cache_timeout);
 }

-----------------------------------------------------------------------

Summary of changes:
 .../lib/OpenILS/Application/Search/Biblio.pm       |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Evergreen ILS