[open-ils-commits] [GIT] Evergreen ILS branch rel_2_4 updated. 355e62809b632b5efc5283cf68b46eea9ba4d22e

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_4 has been updated
       via  355e62809b632b5efc5283cf68b46eea9ba4d22e (commit)
      from  5b60fe5cd2ce35bb48b616d84d9a943dcebd63a2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 355e62809b632b5efc5283cf68b46eea9ba4d22e
Author: Dan Scott <dscott at laurentian.ca>
Date:   Tue Jun 18 12:17:40 2013 -0400

    Prevent uninit var warnings in Search/Biblio.pm
    
    The logger messages in Search/Biblio.pm throw _many_ uninitialized
    variable warnings. With a little care, we can prevent those warnings and
    return our attention to more important log messages.
    
    Signed-off-by: Dan Scott <dscott at laurentian.ca>
    Signed-off-by: Ben Shum <bshum at biblio.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm
index 1b6a9ce..2068128 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm
@@ -1384,7 +1384,10 @@ sub staged_search {
             if $page == 0;
 
         $logger->debug("staged search: located $current_count, with estimated hits=".
-            $summary->{estimated_hit_count}." : visible=".$summary->{visible}.", checked=".$summary->{checked});
+            ($summary->{estimated_hit_count} || "none") .
+            " : visible=" . ($summary->{visible} || "none") . ", checked=" .
+            ($summary->{checked} || "none")
+        );
 
 		if (defined($summary->{estimated_hit_count})) {
             foreach (qw/ checked visible excluded deleted /) {
@@ -1618,7 +1621,9 @@ sub cache_staged_search_page {
     };
 
     $logger->info("staged search: cached with key=$key, superpage=$page, estimated=".
-        $summary->{estimated_hit_count}.", visible=".$summary->{visible});
+        ($summary->{estimated_hit_count} || "none") .
+        ", visible=" . ($summary->{visible} || "none")
+    );
 
     $cache->put_cache($key, $data, $cache_timeout);
 }

-----------------------------------------------------------------------

Summary of changes:
 .../lib/OpenILS/Application/Search/Biblio.pm       |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Evergreen ILS