[open-ils-commits] [GIT] Evergreen ILS branch rel_3_1 updated. 5e5f1c04b958ba5bfa19c38d5af30e2dfe6c0b39

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_1 has been updated
       via  5e5f1c04b958ba5bfa19c38d5af30e2dfe6c0b39 (commit)
      from  8cf7ead11f42ea7cb661497d6609a11713f78371 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5e5f1c04b958ba5bfa19c38d5af30e2dfe6c0b39
Author: Jason Boyer <jboyer at library.in.gov>
Date:   Fri Jun 29 14:09:51 2018 -0400

    LP1779392: Stop sending broken queries
    
    It's possible to send invalid parameters to the
    search.highlight_display_fields function which
    wastes a db roundtrip and fills the logs with
    errors. Checking to be sure there's anything in
    the parameter will prevent both.
    
    Signed-off-by: Jason Boyer <jboyer at library.in.gov>
    Signed-off-by: Mike Rylander <mrylander at gmail.com>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm
index ca3f85a..d0c6bc4 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm
@@ -1317,9 +1317,8 @@ sub fetch_display_fields {
         return;
     }
 
-    my $hl_map_string = "''::HSTORE";
+    my $hl_map_string = "";
     if (ref($highlight_map) =~ /HASH/) {
-        $hl_map_string = "";
         for my $tsq (keys %$highlight_map) {
             my $field_list = join(',', @{$$highlight_map{$tsq}});
             $hl_map_string .= ' || ' if $hl_map_string;
@@ -1330,7 +1329,7 @@ sub fetch_display_fields {
     my $e = new_editor();
 
     for my $record ( @records ) {
-        next unless $record;
+        next unless ($record && $hl_map_string);
         $conn->respond(
             $e->json_query(
                 {from => ['search.highlight_display_fields', $record, $hl_map_string]}

-----------------------------------------------------------------------

Summary of changes:
 .../lib/OpenILS/Application/Search/Biblio.pm       |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
Evergreen ILS