[open-ils-commits] [GIT] Evergreen ILS branch rel_3_0 updated. 1ed3e20ba6884c38a0297ea6646746ebfa44ffb8

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_0 has been updated
       via  1ed3e20ba6884c38a0297ea6646746ebfa44ffb8 (commit)
      from  41fd8d996f9e8be253f9928ac7575e261d41d2ff (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 1ed3e20ba6884c38a0297ea6646746ebfa44ffb8
Author: Mike Rylander <mrylander at gmail.com>
Date:   Fri May 4 09:58:53 2018 -0400

    LP#1755220: Return value checking in offline session fetch
    
    We need to make sure that we receive the correct shape of data (array) rather
    than that we simply got anything when fetching sessions.  In the case of an
    expired session token, we'll receive an ILS Event object informing us of the
    expiration where we'd normally see a list of sessions.
    
    Signed-off-by: Mike Rylander <mrylander at gmail.com>
    Signed-off-by: Dawn Dale <ddale at georgialibraries.org>
    Signed-off-by: Jason Stephenson <jason at sigio.com>

diff --git a/Open-ILS/web/js/ui/default/staff/offline.js b/Open-ILS/web/js/ui/default/staff/offline.js
index 25046b8..fcf1a3d 100644
--- a/Open-ILS/web/js/ui/default/staff/offline.js
+++ b/Open-ILS/web/js/ui/default/staff/offline.js
@@ -126,10 +126,11 @@ function($routeProvider , $locationProvider , $compileProvider) {
             });
         }
 
+        $scope.sessions = [];
         $scope.refreshSessions = function () {
 
             return $http.get(formURL({action:'status',status_type:'sessions'})).then(function(res) {
-                if (res.data) {
+                if (angular.isArray(res.data)) {
                     $scope.sessions = res.data;
                     return $q.when();
                 }

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/ui/default/staff/offline.js |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS