[open-ils-commits] [GIT] Evergreen ILS branch master updated. 1435d7f53f084fe526eb62681b37ef4786c4c1cc

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  1435d7f53f084fe526eb62681b37ef4786c4c1cc (commit)
      from  23719d94411c4d59357ecd37bbc9a8c79a7e5c5c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 1435d7f53f084fe526eb62681b37ef4786c4c1cc
Author: Mike Rylander <mrylander at gmail.com>
Date:   Wed Apr 25 12:32:15 2018 -0400

    LP#1753005: Avoid copy alert error for call numbers with no copies
    
    When displaying the Holdings View tab for a bib in the web staff client,
    if a volume record has no copies, a Javascript error gets thrown.
    
    Item-less volumes still end up in svc.copies at this point, so at the
    moment it is necessary to check whether copy_alerts actually exists.
    Some renaming might also be in order to clarify that svc.copies doesn't
    necessarily contain /only/ fleshed acp records.
    
    Signed-off-by: Mike Rylander <mrylander at gmail.com>
    Signed-off-by: Dan Wells <dbw2 at calvin.edu>

diff --git a/Open-ILS/web/js/ui/default/staff/cat/services/holdings.js b/Open-ILS/web/js/ui/default/staff/cat/services/holdings.js
index e6cc145..eb835f5 100644
--- a/Open-ILS/web/js/ui/default/staff/cat/services/holdings.js
+++ b/Open-ILS/web/js/ui/default/staff/cat/services/holdings.js
@@ -119,7 +119,8 @@ function(egCore , $q) {
 
                 // create virtual field for copy alert count
                 angular.forEach(svc.copies, function (cp) {
-                    cp.copy_alert_count = cp.copy_alerts.length;
+                    if (cp.copy_alerts) cp.copy_alert_count = cp.copy_alerts.length;
+                    else cp.copy_alert_count = 0;
                 });
 
                 // create a label using just the unique part of the owner list

-----------------------------------------------------------------------

Summary of changes:
 .../js/ui/default/staff/cat/services/holdings.js   |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS