[open-ils-commits] [GIT] Evergreen ILS branch master updated. d97b45cd96a293ba3f2c8e406ea19f1bb2aa0616

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  d97b45cd96a293ba3f2c8e406ea19f1bb2aa0616 (commit)
      from  9e939cafa1c66536e0e1620868b503a8fe01c7f6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d97b45cd96a293ba3f2c8e406ea19f1bb2aa0616
Author: James Fournie <jamesrf at users.noreply.github.com>
Date:   Thu May 2 09:53:35 2019 -0700

    LP1751800 - fix fields fields reversing
    
    The pop() here will remove the last item in the array, only to add it
    later with a push() a few lines later.  Instead use a shift() to
    preserve the order.
    
    Signed-off-by: James Fournie <james.fournie at gmail.com>
    Signed-off-by: Remington Steed <rjs7 at calvin.edu>
    Signed-off-by: Dan Wells <dbw2 at calvin.edu>

diff --git a/Open-ILS/web/js/ui/default/staff/reporter/services/template.js b/Open-ILS/web/js/ui/default/staff/reporter/services/template.js
index 043dd47638..39086549ec 100644
--- a/Open-ILS/web/js/ui/default/staff/reporter/services/template.js
+++ b/Open-ILS/web/js/ui/default/staff/reporter/services/template.js
@@ -406,7 +406,7 @@ function($uibModal , $q , egCore , egConfirmDialog , egAlertDialog) {
     service.removeField = function (type, field) {
         var new_list = [];
         while (service[type].length) {
-            var f = service[type].pop();
+            var f = service[type].shift();
             if (field.index != f.index ) new_list.push(f);
         }
         new_list.forEach(function(f) {

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/ui/default/staff/reporter/services/template.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
Evergreen ILS