[open-ils-commits] [GIT] Evergreen ILS branch rel_3_3 updated. 548601ece159a628829ef3ca8126ffe96c7ca01e

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_3 has been updated
       via  548601ece159a628829ef3ca8126ffe96c7ca01e (commit)
      from  bf37b1e3efa16a2a67aa0902a42afc4616b23cf6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 548601ece159a628829ef3ca8126ffe96c7ca01e
Author: James Fournie <jamesrf at users.noreply.github.com>
Date:   Thu May 2 09:53:35 2019 -0700

    LP1751800 - fix fields fields reversing
    
    The pop() here will remove the last item in the array, only to add it
    later with a push() a few lines later.  Instead use a shift() to
    preserve the order.
    
    Signed-off-by: James Fournie <james.fournie at gmail.com>
    Signed-off-by: Remington Steed <rjs7 at calvin.edu>
    Signed-off-by: Dan Wells <dbw2 at calvin.edu>

diff --git a/Open-ILS/web/js/ui/default/staff/reporter/services/template.js b/Open-ILS/web/js/ui/default/staff/reporter/services/template.js
index 043dd47638..39086549ec 100644
--- a/Open-ILS/web/js/ui/default/staff/reporter/services/template.js
+++ b/Open-ILS/web/js/ui/default/staff/reporter/services/template.js
@@ -406,7 +406,7 @@ function($uibModal , $q , egCore , egConfirmDialog , egAlertDialog) {
     service.removeField = function (type, field) {
         var new_list = [];
         while (service[type].length) {
-            var f = service[type].pop();
+            var f = service[type].shift();
             if (field.index != f.index ) new_list.push(f);
         }
         new_list.forEach(function(f) {

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/ui/default/staff/reporter/services/template.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
Evergreen ILS