[open-ils-commits] [GIT] Evergreen ILS branch master updated. 83e278e8a4298ddc54d1c15ccd84b55b188717fe

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  83e278e8a4298ddc54d1c15ccd84b55b188717fe (commit)
      from  0aaf9f8940b0dc3c0e0486bb685485e0dd6acd27 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 83e278e8a4298ddc54d1c15ccd84b55b188717fe
Author: Jason Stephenson <jason at sigio.com>
Date:   Thu May 2 08:36:15 2019 -0400

    LP 1827250: Fix Last Captured Hold Check for Holds Shelf
    
    When the current copy on an on shelf hold is the same as that on some
    uncaptured holds, the hold fails to appear on the hold shelf when it
    should.  This comes down to some SQL in the storage function to
    retrieve wide holds: open-ils.storage.action.live_holds.wide_hash.
    
    The intent of the new code is to check that the current hold matches
    the most recently captured hold for the copy.  However, the order by
    in the query fails to take into account holds with a NULL capture time
    on the same copy will sort before the captured holds.  This patch
    rectifies this situation by adding "NULLS LAST" to the order by.
    
    Signed-off-by: Jason Stephenson <jason at sigio.com>
    Signed-off-by: Michele Morgan <mmorgan at noblenet.org>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
index f987d3b973..213ed59e5a 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
@@ -2146,7 +2146,7 @@ sub wide_hold_data {
                 SELECT  id
                   FROM  action.hold_request recheck
                   WHERE recheck.current_copy = cp.id
-                  ORDER BY capture_time DESC
+                  ORDER BY capture_time DESC NULLS LAST
                   LIMIT 1
             )))
         SQL

-----------------------------------------------------------------------

Summary of changes:
 .../src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
Evergreen ILS