[open-ils-commits] [GIT] Evergreen ILS branch rel_3_2 updated. abd84c5e46529c88e72e8fb669505a1b4068fd3f

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_2 has been updated
       via  abd84c5e46529c88e72e8fb669505a1b4068fd3f (commit)
      from  c23a03432bd6837fbcf3b65536227e62d385f7dd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit abd84c5e46529c88e72e8fb669505a1b4068fd3f
Author: Jason Stephenson <jason at sigio.com>
Date:   Thu May 2 08:36:15 2019 -0400

    LP 1827250: Fix Last Captured Hold Check for Holds Shelf
    
    When the current copy on an on shelf hold is the same as that on some
    uncaptured holds, the hold fails to appear on the hold shelf when it
    should.  This comes down to some SQL in the storage function to
    retrieve wide holds: open-ils.storage.action.live_holds.wide_hash.
    
    The intent of the new code is to check that the current hold matches
    the most recently captured hold for the copy.  However, the order by
    in the query fails to take into account holds with a NULL capture time
    on the same copy will sort before the captured holds.  This patch
    rectifies this situation by adding "NULLS LAST" to the order by.
    
    Signed-off-by: Jason Stephenson <jason at sigio.com>
    Signed-off-by: Michele Morgan <mmorgan at noblenet.org>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
index 38ff40d136..88eea0af47 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
@@ -2137,7 +2137,7 @@ sub wide_hold_data {
                 SELECT  id
                   FROM  action.hold_request recheck
                   WHERE recheck.current_copy = cp.id
-                  ORDER BY capture_time DESC
+                  ORDER BY capture_time DESC NULLS LAST
                   LIMIT 1
             )))
         SQL

-----------------------------------------------------------------------

Summary of changes:
 .../src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
Evergreen ILS