[open-ils-commits] [GIT] Evergreen ILS branch rel_3_3 updated. ede95b92fcd00a75dd63b6b496c1585bea800387

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_3 has been updated
       via  ede95b92fcd00a75dd63b6b496c1585bea800387 (commit)
      from  c83967ae7a3954a8bfda69344707a0d163507338 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ede95b92fcd00a75dd63b6b496c1585bea800387
Author: Galen Charlton <gmc at equinoxinitiative.org>
Date:   Mon Jun 22 11:40:08 2020 -0400

    LP#1844365: fix initialization of stat cats in patron registration form
    
    If you edit a patron and it has (or gets added) a stat cat entry,
    then from the registration form click on its inline patron search
    link, fetch a patron that has no stat cats, then edit it, the
    first patron's stat cats can show up in the registration form.
    If the second patron does have stat cats, but not values set
    for all of them, then the first patron's stat cat entries can
    fill in cases where no entry was previously set.
    
    This patch fixes patronRegSvc's initialization when loading
    an existing patron record to avoid this.
    
    To test
    -------
    [1] Edit a patron and ensure that it has at least one
        statistical category set.
    [2] From the patron search link in the patron app tab
        bar, NOT the Search | Patron menu item, search for
        and retrieve a patron that has no stat cats assigned.
    [3] Edit the patron. Observe that the first patron's
        stat cat entry displays in the second patron's
        registration form.
    [4] Apply the patch and repeats steps 1-3. This time,
        the previous patron's stat cats should not infect
        the second patron's registration form.
    
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
    Signed-off-by: Mike Risher <mrisher at catalyte.io>

diff --git a/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js b/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js
index f70374173c..6e1da72f69 100644
--- a/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js
+++ b/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js
@@ -803,6 +803,7 @@ angular.module('egCoreMod')
 
         // toss entries for existing stat cat maps into our living 
         // stat cat entry map, which is modified within the template.
+        service.stat_cat_entry_maps = [];
         angular.forEach(patron.stat_cat_entries, function(map) {
             service.stat_cat_entry_maps[map.stat_cat.id] = map.stat_cat_entry;
         });

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js | 1 +
 1 file changed, 1 insertion(+)


hooks/post-receive
-- 
Evergreen ILS