[open-ils-commits] [GIT] Evergreen ILS branch rel_3_4 updated. d2534cdc70601b29269b2894ea0a0deec9203d96
Evergreen Git
git at git.evergreen-ils.org
Mon Jul 20 17:34:11 EDT 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".
The branch, rel_3_4 has been updated
via d2534cdc70601b29269b2894ea0a0deec9203d96 (commit)
from 5418f1b851eb79c323dfaf72f321dbedf49ff3c6 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit d2534cdc70601b29269b2894ea0a0deec9203d96
Author: Galen Charlton <gmc at equinoxinitiative.org>
Date: Mon Jun 22 11:40:08 2020 -0400
LP#1844365: fix initialization of stat cats in patron registration form
If you edit a patron and it has (or gets added) a stat cat entry,
then from the registration form click on its inline patron search
link, fetch a patron that has no stat cats, then edit it, the
first patron's stat cats can show up in the registration form.
If the second patron does have stat cats, but not values set
for all of them, then the first patron's stat cat entries can
fill in cases where no entry was previously set.
This patch fixes patronRegSvc's initialization when loading
an existing patron record to avoid this.
To test
-------
[1] Edit a patron and ensure that it has at least one
statistical category set.
[2] From the patron search link in the patron app tab
bar, NOT the Search | Patron menu item, search for
and retrieve a patron that has no stat cats assigned.
[3] Edit the patron. Observe that the first patron's
stat cat entry displays in the second patron's
registration form.
[4] Apply the patch and repeats steps 1-3. This time,
the previous patron's stat cats should not infect
the second patron's registration form.
Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
Signed-off-by: Mike Risher <mrisher at catalyte.io>
diff --git a/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js b/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js
index fdf6f86cd8..6e7e932953 100644
--- a/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js
+++ b/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js
@@ -804,6 +804,7 @@ angular.module('egCoreMod')
// toss entries for existing stat cat maps into our living
// stat cat entry map, which is modified within the template.
+ service.stat_cat_entry_maps = [];
angular.forEach(patron.stat_cat_entries, function(map) {
service.stat_cat_entry_maps[map.stat_cat.id] = map.stat_cat_entry;
});
-----------------------------------------------------------------------
Summary of changes:
Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js | 1 +
1 file changed, 1 insertion(+)
hooks/post-receive
--
Evergreen ILS
More information about the open-ils-commits
mailing list