[OPEN-ILS-DEV] Re: [open-ils-commits] r7663 - trunk/Open-ILS/xul/staff_client/server/locale/en-US

[Dan Scott]

On 14/08/07, svn at svn.open-ils.org <svn at svn.open-ils.org> wrote:
> Author: phasefx
> Date: 2007-08-14 12:44:39 -0400 (Tue, 14 Aug 2007)
> New Revision: 7663
>
> Modified:
>    trunk/Open-ILS/xul/staff_client/server/locale/en-US/cat.properties
> Log:
> %s, not %S
>
> Modified: trunk/Open-ILS/xul/staff_client/server/locale/en-US/cat.properties
> ===================================================================
> --- trunk/Open-ILS/xul/staff_client/server/locale/en-US/cat.properties  2007-08-14 16:44:03 UTC (rev 7662)
> +++ trunk/Open-ILS/xul/staff_client/server/locale/en-US/cat.properties  2007-08-14 16:44:39 UTC (rev 7663)
> @@ -1,2 +1,2 @@
> -cat.barcode_for_item=The barcode for the item is %1$S
> -cat.batch_operation_failed=The whole batch operation failed. %1$S
> +cat.barcode_for_item=The barcode for the item is %1$s
> +cat.batch_operation_failed=The whole batch operation failed. %1$s
>

This commit worries me a bit.

http://developer.mozilla.org/en/docs/XUL_Tutorial:Property_Files
clearly shows upper-case $S being used, and that's what I've used in
previous commits (and testing with the built-in chrome
stringbundleset/stringbundle interface showed that it worked). Are you
sure you want to use lower-case here?

"My idea of a vacation != other people's idea of a vacation",

-- 
Dan Scott
Laurentian University