[OPEN-ILS-DEV] PATCH: settings-tester.pl

[Dan Scott]

On 01/12/2007, Mike Rylander <mrylander at gmail.com> wrote:
> On Dec 1, 2007 12:40 PM, Ben Ostrowsky <benostrowsky at gmail.com> wrote:
> > 112a113,116
> > >       if (!$db_pw) {
> > >               $db_pw = $database->findvalue("./password");
> > >       }
> > >
> >
> > This catches the opensrf.xml section in which the password is in a
> > <password> element rather than a <pw> element.
> >
>
> Neither open-ils.storage nor open-ils.cstore use the <password>
> element.  The general <reporter> section does as of 1.2, but I have
> changed that in trunk to match the other services' use of <pw>.  I've
> also added a deprecation note to settings tester, along with a variant
> of the patch you suggested.  Check out the newest version from trunk
> and see if that works for you?

I just cleaned it up a little further; xpath '../../local-name()' was
throwing an invalid expression for me (although it looks pretty valid
to me!).

Ben also noted in IRC that the <driver> section triggers a warning
because no <language> is specified. I rejiggered the logic to avoid
checking for a <language> section when the xpath includes <reporter>
(previous logic would throw a warning about an uninitialized variable,
now that I turned on warnings and strict).

-- 
Dan Scott
Laurentian University