SPAM: Re: [OPEN-ILS-DEV] SPAM: PATCH: i18n support for OPAC

[Bill Erickson]

On 6/7/07, Dan Scott <denials at gmail.com> wrote:
>
> On 05/06/07, Dan Scott <denials at gmail.com> wrote:
> > The strings for the default skin in the OPAC were halfway between
> > entities defined in DTDs (good!) and hardcoded into the OPAC files
> > (not so good).
> >
> > This patch moves the remaining strings from the default skin in the
> > OPAC into the locale/en-US/opac.dtd file. Tested with CVS HEAD.
> >
>
> Wow - sending patches at 1:09 am is probably a bad idea. Especially
> when you look over your work the following day and realize that your
> claim of moving all the strings into entities from the default skin
> was off by about, oh, 70% of the actual work.
>
> This patch, on the other hand, is being sent at just past midnight my
> time, which means that it is both much more trustworthy and much more
> complete.
>
> There were a few editorial changes made to the content of the strings
> displayed in the interface - one or two spelling and grammatical
> corrections, and changing (??) to (Help) for slightly more clarity.
> Some of the entities contain HTML markup, which is not ideal, but
> lacking a rewrite of the content or a sprintf implementation in XML
> it's the best I could do in a short time frame.
>
> I will send a separate patch for the more troublesome I18N string --
> the results string, that is composed of several substrings and values
> concatenated together, cannot remain that way. Jason had a good
> suggestion that I will run past the team for comments.
>
> --
> Dan Scott
> Laurentian University
>
>
Awesome!  Patch applied, committed, and working well on dev.  For everyone's
sake, I also removed the unused .dtd files from
Open-ILS/web/opac/locale/en-US/.  We only use opac.dtd and lang.dtd.

Thanks, Dan!

-bill

-- 
Bill Erickson
PINES Systems Developer
Georgia Public Library Service
billserickson at gmail.com
http://open-ils.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20070607/01eb02ef/attachment.html