[OPEN-ILS-DEV] PATCH: oils_requestor.c memory leaks

[Scott McKellar]

I've been providing context diffs because that's the style requested
at:

http://open-ils.org/documentation/contributing.html#Submitting%20a%20Patch

If you open a context .patch file in Konqueror it presents a very nice
display with old code on the left, new code on the right, and
color-coded bands connecting corresponding pieces.  At least it
does on my system, which is Suse 9.3 using KDE.  I don't know if 
there are any other such tools out there.

As for style: I have tried to follow the practices in the existing
code, so far as I can discern them, curly brace placement in 
particular.  I don't know that I have always succeeded.  Whether
the prevailing practices are the best practices is another question.

One change that I forgot to mention in my last posting: I removed a
redundant pair of parentheses around the "while" condition.

Scott McKellar
http://home.swbell.net/mck9/aargh/

--- Jeroen Ruigrok van der Werven <asmodai at in-nomine.org> wrote:

> Hi Scott,
> 
> -On [20070504 08:10], Scott McKellar (mck9 at swbell.net) wrote:
> >The attached patch plugs some memory leaks and tidies up a few other
> >things in ILS/Open-ILS/src/extras/oils_requestor.c.
> 
> Is there any possibility for unified diffs? I find context diffs a
> bit hard to
> peer review.
> 
> What I saw thus far looked ok, so +1 from me.
> 
> Only thing I wondered about is the overal style in the sources. I
> guess the
> extraneous spaces around parentheses is the project's style, but are
> function
> return value assignments supposed to be without spaces?
> 
> E.g.: if (blah=function()) { instead of if (blah = function()) {
> 
> -- 
> Jeroen Ruigrok van der Werven <asmodai(-at-)in-nomine.org> / asmodai
> イェルーン ラウフロック ヴァン デル
> ウェルヴェン
> http://www.in-nomine.org/ | http://www.rangaku.org/
> Nature does nothing uselessly...
>