[OPEN-ILS-DEV] Re: Schema typo patch

[Dan Scott]

And attached for real this time, the schema migration script. Jeez.

On 21/05/07, Dan Scott <denials at gmail.com> wrote:
> On 20/05/07, Dan Scott <denials at gmail.com> wrote:
> > While waiting for some bib records to load (yay -- another past
> > another milestone), I was browsing through the schemas for Evergreen
> > and noticed some typos. I have to submit this patch once, and if it's
> > not applied I understand given the potential pain for schema migration
> > at PINES, but there's something in my English major /
> > newspaper-editing / tech writer past that needs to get this out. And
> > it would be nice for the rest of us to start with a schema that
> > doesn't suffer from minor typos...
> >
> > Testing consisted of applying the patch to CVS HEAD, loading the
> > Gutenberg records, and browsing through the records in the staff
> > client. Given that this touches "recuring_fines" and "persistant",
> > this level of testing wouldn't flush anything out. However, the patch
> > was created by running "find /ILS -exec grep -Hi recuring {} \;" for
> > the affected words through the source tree, so I'm sure that any
> > in-tree code relying on the old spellings has been cleaned up.
> >
> > The DCO is probably overkill for a typo patch, but whatever :)
> >
> > Developer's Certificate of Origin 1.1 By making a contribution to this
> > project, I certify that:
> >
> > (a) The contribution was created in whole or in part by me and I have
> > the right to submit it under the open source license indicated in the
> > file; or
> >
> > (b) The contribution is based upon previous work that, to the best of
> > my knowledge, is covered under an appropriate open source license and
> > I have the right under that license to submit that work with
> > modifications, whether created in whole or in part by me, under the
> > same open source license (unless I am permitted to submit under a
> > different license), as indicated in the file; or
> >
> > (c) The contribution was provided directly to me by some other person
> > who certified (a), (b) or (c) and I have not modified it; and
> >
> > (d) In the case of each of (a), (b), or (c), I understand and agree
> > that this project and the contribution are public and that a record of
> > the contribution (including all personal information I submit with it,
> > including my sign-off) is maintained indefinitely and may be
> > redistributed consistent with this project or the open source license
> > indicated in the file.
> >
> > --
> > Dan Scott
> > Laurentian University
> >
> >
>
> Update: now includes a schema migration script, which is probably a
> more interesting development than mere typo corrections. And the patch
> was created using context diff (-c), per the development instructions.
>
> Known issues:
>  * the migration script is probably erroneously labelled
> schema_migration_10_to_12.sql (as I haven't tracked any of the other
> changes from 1.0.x to 1.2.x)
>  * I haven't created a Makefile target for the migration script
> (openils_db_upgrade or the like) as depending on one's configuration
> it may be necessary to run the migration script through EXECUTE SCRIPT
> to replicate the action on all nodes
>
> Further justification for typo fixes - especially with "tansparency"
> or "tranparency" vs. "transparency", and to a lesser extent for
> recuring / recurance, I _know_ that I would end up tripping over that
> some time in the future as I struggle to figure out why my perfectly
> sensible SQL was erroring out. Plus it gives a little more polish to
> the code :)
>
> Developer's Certificate of Origin 1.1 By making a contribution to this
> project, I certify that:
>
> (a) The contribution was created in whole or in part by me and I have
> the right to submit it under the open source license indicated in the
> file; or
>
> (b) The contribution is based upon previous work that, to the best of
> my knowledge, is covered under an appropriate open source license and
> I have the right under that license to submit that work with
> modifications, whether created in whole or in part by me, under the
> same open source license (unless I am permitted to submit under a
> different license), as indicated in the file; or
>
> (c) The contribution was provided directly to me by some other person
> who certified (a), (b) or (c) and I have not modified it; and
>
> (d) In the case of each of (a), (b), or (c), I understand and agree
> that this project and the contribution are public and that a record of
> the contribution (including all personal information I submit with it,
> including my sign-off) is maintained indefinitely and may be
> redistributed consistent with this project or the open source license
> indicated in the file.
>
> --
> Dan Scott
> Laurentian University
>
>


-- 
Dan Scott
Laurentian University
-------------- next part --------------
A non-text attachment was scrubbed...
Name: schema_migration_10_to_12.sql
Type: application/octet-stream
Size: 980 bytes
Desc: not available
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20070521/07444bda/schema_migration_10_to_12-0001.obj