[OPEN-ILS-DEV] PATCH: osrf_system.c

[Mike Rylander]

This, along with patches 3 and 4, and patch 1 for osrf_system.h
(several previous messages) have been applied.

JFYI, I'm linking to the patch emails in the list archives from within
the changelog messages, in case anyone wants to follow along with
either our changelog (HUGE) or your own cvs-history-watching thingy.

--miker

On 5/28/07, Scott McKellar <mck9 at swbell.net> wrote:
> I return once more to osrf_system_bootstrap_client_resc(), this time
> with two unrelated tweaks.
>
> 1. In my last post I noted that we cannot connect unless we have
> either a UNIX path or a non-zero port number.  I submitted a patch
> to detect and report this condition in session_connect().
>
> In this patch, I apply the same test further upstream, so that the
> problem can be attributed to a specific configuration file.
>
> 2. After assembling most of the necessary configuration items, we
> log a message with the domain, port, and unixpath.  However if there
> is no unixpath, we wind up passing a NULL for it.
>
> Apparently, glibc represents a NULL in a string context as "(null)".
> However we cannot assume that all implementations will be so helpful
> in implementing undefined behavior.  I tweaked the code so that, if
> unixpath is NULL, we pass "(none)" for it.
>
> Suggestion: if you grep your logs for "(null)", you will likely find
> other places where we sometimes pass NULLs when we shouldn't.  I
> myself don't have a good enough log collection to help out.
>
> Scott McKellar
> http://home.swbell.net/mck9/aargh/
>
> Developer's Certificate of Origin 1.1 By making a contribution to
> this project, I certify that:
>
> (a) The contribution was created in whole or in part by me and I
> have the right to submit it under the open source license indicated
> in the file; or
>
> (b) The contribution is based upon previous work that, to the best
> of my knowledge, is covered under an appropriate open source license
> and I have the right under that license to submit that work with
> modifications, whether created in whole or in part by me, under the
> same open source license (unless I am permitted to submit under a
> different license), as indicated in the file; or
>
> (c) The contribution was provided directly to me by some other person
> who certified (a), (b) or (c) and I have not modified it; and
>
> (d) In the case of each of (a), (b), or (c), I understand and agree
> that this project and the contribution are public and that a record
> of the contribution (including all personal information I submit
> with it, including my sign-off) is maintained indefinitely and may
> be redistributed consistent with this project or the open source
> license indicated in the file.
>


-- 
Mike Rylander