[OPEN-ILS-DEV] PATCH: osrf_json_xml.c (mostly const-correctness)

Scott McKellar mck9 at swbell.net
Sat Nov 3 12:52:04 EDT 2007


This patch applies the const qualifier to various parameters.  In
addition:

1. In a couple of places I replaced buffer_data() and buffer_free()
with buffer_release(), in order to avoid a round of malloc() and
free().

2. I moved several local variables from function scope to a narrower
block scope, on the principal that a narrower scope is preferable to 
a wider scope.

3. In _recurse_jsonObjectToXML(), in the branch for JSON_BOOL: I
eliminated the need to allocate and deallocate a buffer for the 
bool_val variable.

Scott McKellar
http://home.swbell.net/mck9/ct/

Developer's Certificate of Origin 1.1 By making a contribution to
this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license indicated
in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source license
and I have the right under that license to submit that work with
modifications, whether created in whole or in part by me, under the
same open source license (unless I am permitted to submit under a
different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person
who certified (a), (b) or (c) and I have not modified it; and

(d) In the case of each of (a), (b), or (c), I understand and agree
that this project and the contribution are public and that a record
of the contribution (including all personal information I submit
with it, including my sign-off) is maintained indefinitely and may
be redistributed consistent with this project or the open source
license indicated in the file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osrf_json_xml_c_1.patch
Type: text/x-patch
Size: 4665 bytes
Desc: 259873341-osrf_json_xml_c_1.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20071103/122f8f7d/osrf_json_xml_c_1.bin


More information about the Open-ils-dev mailing list