[OPEN-ILS-DEV] PATCH: utils.[ch] (const correctness)

[Mike Rylander]

On Nov 11, 2007 9:10 PM, Scott McKellar <mck9 at swbell.net> wrote:
> These patches apply the const qualifier to several function
> parameters.
>
> In two cases, they also replace an empty parameter list with "void".

Scott, I've individually eyeballed all of your current outstanding
patches, from "PATCH: osrf_app_session.[ch] (const-correctness)" on
Oct 27 through this one, and I'm ready to go through and push them in.
 But (there's always a but...) it would be tremendously helpful to me
if you could diff your current modified working directory and send a
single patch of the uncommitted modifications you've sent so far.

I've tried to avoid asking for resubmission to this point because I
know it can be a big pain (and we want to cause you the least amount
of pain we can ;) ), but between several short traveling stints and a
new production migration, the last few weeks have been too hectic to
find the time to sit down an push your patches in, and I don't want
them to slip any longer.  A single patch against the current trunk
code would help me get your changes in right away.

Is this feasible on your end?

(FWIW, svn could help streamline you patch creation with the diff subcommand.)

TIA,

--miker

>
> Scott McKellar
> http://home.swbell.net/mck9/ct/
>
> Developer's Certificate of Origin 1.1 By making a contribution to
> this project, I certify that:
>
> (a) The contribution was created in whole or in part by me and I
> have the right to submit it under the open source license indicated
> in the file; or
>
> (b) The contribution is based upon previous work that, to the best
> of my knowledge, is covered under an appropriate open source license
> and I have the right under that license to submit that work with
> modifications, whether created in whole or in part by me, under the
> same open source license (unless I am permitted to submit under a
> different license), as indicated in the file; or
>
> (c) The contribution was provided directly to me by some other person
> who certified (a), (b) or (c) and I have not modified it; and
>
> (d) In the case of each of (a), (b), or (c), I understand and agree
> that this project and the contribution are public and that a record
> of the contribution (including all personal information I submit
> with it, including my sign-off) is maintained indefinitely and may
> be redistributed consistent with this project or the open source
> license indicated in the file.



-- 
Mike Rylander
 | VP, Research and Design
 | Equinox Software, Inc. / The Evergreen Experts
 | phone:  1-877-OPEN-ILS (673-6457)
 | email:  miker at esilibrary.com
 | web:  http://www.esilibrary.com