[OPEN-ILS-DEV] PATCH: osrf_version.c

Scott McKellar mck9 at swbell.net
Sun Oct 28 10:18:54 EDT 2007


This patch declares four internal pointer variables as const.

Each of these pointers is assigned a return value from either 
jsonObjectGetIndex() or jsonObjectGetString().  By declaring them 
const we prepare for the day when these functions are redefined to 
return const pointers.

This patch relies on a previous patch to osrf_app_session.[ch],
which hasn't been applied yet.

-----------

Is there a good reason why the functions defined in osrf_version.c
are not prototyped in any header?  The policy appears to be to 
prototype them separately in every file that references them.

Scott McKellar
http://home.swbell.net/mck9/ct/

Developer's Certificate of Origin 1.1 By making a contribution to
this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license indicated
in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source license
and I have the right under that license to submit that work with
modifications, whether created in whole or in part by me, under the
same open source license (unless I am permitted to submit under a
different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person
who certified (a), (b) or (c) and I have not modified it; and

(d) In the case of each of (a), (b), or (c), I understand and agree
that this project and the contribution are public and that a record
of the contribution (including all personal information I submit
with it, including my sign-off) is maintained indefinitely and may
be redistributed consistent with this project or the open source
license indicated in the file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osrf_version_c_1.patch
Type: text/x-patch
Size: 840 bytes
Desc: 3596141317-osrf_version_c_1.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20071028/5cccb9fe/osrf_version_c_1.bin


More information about the Open-ils-dev mailing list