[OPEN-ILS-DEV] Circ problem with 1.2.3.0?

[Garry Dunn]

Bill Erickson wrote:
> On Fri, 15 Aug 2008 06:14:18 -0400, Garry Dunn 
> <garry at trellisconsulting.ca> wrote:
> 
>> Mike Rylander wrote:
>>> On Thu, Aug 14, 2008 at 10:34 AM, Garry Dunn 
>>> <garry at trellisconsulting.ca> wrote:
>>>> To all,
>>>>
>>>> I just recently upgraded (from 1.2.2.0) to 1.2.3.0 (going through 
>>>> each of
>>>> the minor upgrades between) and now I can't check a book out.  I've 
>>>> upgraded
>>>> both the server and the client.  I'm hoping someone can point me in the
>>>> right direction.
>>>>
>>>> The error I get is:
>>>>
>>>> method=open-ils.circ.checkout
>>>> params=["27e22ed97a705d7c17cc5a8bb41c2838",{"barcode":"1234","patron":2,"permit_key":"4f9f0412833fc870 
>>>>
>>>> bae69de74be90fb0"},0]
>>>> THROWN:
>>>> {"payload":[],"debug":"osrfMethodException :  *** Call to
>>>> [open-ils.circ.checkout] failed for session
>>>> [1218719016.028563.121871901617073], thread trace [1]:\n  * ! 
>>>> EXCEPTION ! *
>>>> \nTYPE: OpenSRF::EX::ERROR
>>>> \nMess: System ERROR \nMess: Circ Duration Script Died: Error: 
>>>> TypeError:
>>>> parent has no properties at line 163: (null)\nLoc.: 185 
>>>> OpenSRF::Application
>>>> \nLoc.: /openils/lib/perl5/OpenSRF/Application.pm \nTime: Thu Aug 14
>>>> 09:03:36 2008\n\n","status":500}
>>>> STATUS:
>>>>
>>>> I get this on a 'blank' database (no Gutenberg records or any of our 
>>>> records
>>>> imported).  I created 1 book and 1 patron and tried to get that 
>>>> patron to
>>>> checkout that book.
>>>  Any chance you added your user to the User group (at the top of the
>>> tree, and which has no parent group)?  My theory is that it's either
>>> that, or there is a group mentioned in the JS that does not exist in
>>> the database.  If it's the former, that User group is mainly intended
>>> to be a parent group for others, such as Patron and Staff.
>>>
>>
>> The patron is a member of the 'Patrons' group.  I left the groups and 
>> permissions alone when the database was created, so it's got the 
>> default that comes with Evergreen.
>>
>> Where would I look in the JS for other groups?  I know I 'autogen-ed' 
>> after importing the data (the old library hierarchy would've existed). 
>> The exact same data (from the old ILS) imports properly into 1.2.2.0 
>> (and 1.2.3.0).  1.2.2.0 will let me circulate books, but 1.2.3.0 won't.
>>
>> Thanks for the help.
> 
> 
> Garry,
> 
> I committed code to handle this situation more gracefully in 1.2.3 and 
> trunk:  http://svn.open-ils.org/trac/ILS/changeset/10366
> 
> It would be safe/trivial to merge this change into your installed system 
> at /openils/var/circ/circ_lib.js.
> 
> It sill sounds, however, like the user being checked is not in a valid 
> group.  Can you make sure there is no small descrepency between group 
> names?  For example "Patron" vs. "Patrons"?
> 
> -b
> 
> 

Bill,

Thanks for the patch.  I'll apply it and see what happens.

I was able to do a full make (all targets on 1.2.3.0) and then add a 
book, patron and check that book out to that patron--it worked fine. 
(We're still playing with test data so I didn't care about wiping the 
database.)  When I added the patron, I select the 'Patrons' group from 
the drop down box, so I don't know how there could be a discrepancy.  I 
think I did something wrong during the upgrade process (missed a step 
perhaps?).

Now off to see if I can get our data to import and work...

Thanks again.