[OPEN-ILS-DEV] Lost item handling

[Mike Rylander]

On Fri, Dec 19, 2008 at 10:55 AM, Bill Ott <bott at grpl.org> wrote:
> Before we're completely buried in snow, I thought I'd show my work and get
> some initial comments.
>>
>> Short story:
>> 1)  "void lost on checkin" is in the works (but see below)
>> 2) maybe? ;)  depends on what you're looking for
>> 3) they generally are, however, I have an opinion about the
>> circ.lost_immediately_available setting
>>
>
> I'm actually surprised there is a short story. ;-)

Well, there's not really. ;)

[snip]

> Again, showing what I've done quick-n-dirty.  It's also only against 1.2.4,
> as I don't have all my other goodies merged into 1.4 yet, but for what it's
> worth...
>

In hopes of encouraging continuation, I offer a DryTechnicalReview(tm).  ;)

<dry technical review>

My only style comment is a request to use 'if' instead of 'unless' for
the multi-condition test at Circulate.pm:1925.  The logic reversals
get ... complicated ... during debugging. ;)  I've hurt myself with
this, and following other's code is even harder (you lack the original
logical context).

It looks like we're loosing the fallback code in the original
Circulate.pm at lines 1927-1928 which set the copy status to
reshelving if there are no matched conditions.  It looks like this
should be in its own 'else' block at the end of the new code, instead
of inside the 'elsif ($stat == OILS_COPY_STATUS_LOST)' branch.

IMO the unvoiding of overdue billings should be separated out from
checkin_handle_lost_now_found, since it's wasted effort to do that
twice in the case of both voiding the lost and lost processing fees.

</dry technical review>

Then there's the UI part, but that's later.

All in all, it's definitely on the right track and is looking good.
Thank you for sharing early!

-- 
Mike Rylander
 | VP, Research and Design
 | Equinox Software, Inc. / The Evergreen Experts
 | phone:  1-877-OPEN-ILS (673-6457)
 | email:  miker at esilibrary.com
 | web:  http://www.esilibrary.com