[OPEN-ILS-DEV] Patch for examples/apache/eg_vhost.conf

[Dan Scott]

I think the first part of that patch is wrong, unfortunately:

http://httpd.apache.org/docs/2.2/mod/mod_env.html#setenv

states that the syntax for SetEnv is:

SetEnv env-variable value

That is, no "=" sign is used for the variable assignment. If you do
use the equals sign, you end up setting an environment variable named
"locale=en-US" to null and the locale environment variable isn't set
at all. That's why I committed changeset 8432.

If you use SetEnvIf, however, the "=" sign is required. Thanks for the
consistency, Apache :)

If you leave the current version of the file unmodified (e.g. "SetEnv
locale en-US") then I think the second <LocationMatch> section that
your patch adds is unnecessary, because locale will already be set to
en-US. So I don't think any changes should be committed.

Dan

On 16/02/2008, John Craig <jc-mailinglist at alphagconsulting.com> wrote:
>
>  Here's one of the changes Jason and I figured out yesterday in trying to
> get the trunk Staff Client to connect to a test trunk DB. The diff returned
> rather more than Jason and I had changed, so I assume that dbs and berick
> have other changes in hand (since they'd advised me on other changes to the
> exercised version of this file (the one in /etc/apache2).
>
>
>  ILS/Open-ILS/examples/apache/eg_vhost.conf.patch
>
>  Index: eg_vhost.conf
> ===================================================================
>  --- eg_vhost.conf       (revision 8760)
>  +++ eg_vhost.conf       (working copy)
>  @@ -107,7 +107,7 @@
>       allow from all
>
>       # We only support one locale (en-US) for the time being
>  -    SetEnv locale en-US
>  +    SetEnv locale=en-US
>   </LocationMatch>
>
>   <LocationMatch /xul/.*\.xul$>
>  @@ -117,10 +117,10 @@
>       allow from all
>
>       # We only support one locale (en-US) for the time being
>  -    SetEnv locale en-US
>  +    SetEnvIf Request_URI ".*" locale=en-US
>   </LocationMatch>
>
>
>
> Developer's Certificate of Origin 1.1
>
> Developer's Certificate of Origin 1.1 By making a contribution to this
> project, I certify that:
>
> (a) The contribution was created in whole or in part by me and I have the
> right to submit it under the open source license indicated in the file; or
>
> (b) The contribution is based upon previous work that, to the best of my
> knowledge, is covered under an appropriate open source license and I have
> the right under that license to submit that work with modifications, whether
> created in whole or in part by me, under the same open source license
> (unless I am permitted to submit under a different license), as indicated in
> the file; or
>
> (c) The contribution was provided directly to me by some other person who
> certified (a), (b) or (c) and I have not modified it; and
>
> (d) In the case of each of (a), (b), or (c), I understand and agree that
> this project and the contribution are public and that a record of the
> contribution (including all personal information I submit with it, including
> my sign-off) is maintained indefinitely and may be redistributed consistent
> with this project or the open source license indicated in the file.
>  John M. Craig
>  Alpha-G Consulting, LLC
>  john at alphagconsulting.com
>  www.alphagconsulting.com
>
>


-- 
Dan Scott
Laurentian University