[OPEN-ILS-DEV] PATCH: osrf_stack.[ch] (memory leak)

Scott McKellar mck9 at swbell.net
Sun Jan 6 12:48:23 EST 2008


This patch plugs a minor memory leak and cleans up some miscellaneous
things.

Summary:

1. I moved almost everything from the header into the implementation
file, since it isn't referenced elsewhere.  All that's left is one
prototype and some nested #includes.

2. I moved the nested #includes inside the compilation guard.

3. Except for osrf_stack_transport_handler(), all functions are now
static.

4. I applied the const qualifier to the second parameter of
osrf_stack_transport_handler().

5. I plugged a memory leak in osrf_stack_transport_handler().  When
unable to open a session, we were returning without freeing the
input message.

Scott McKellar
http://home.swbell.net/mck9/ct/

Developer's Certificate of Origin 1.1 By making a contribution to
this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license indicated
in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source license
and I have the right under that license to submit that work with
modifications, whether created in whole or in part by me, under the
same open source license (unless I am permitted to submit under a
different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person
who certified (a), (b) or (c) and I have not modified it; and

(d) In the case of each of (a), (b), or (c), I understand and agree
that this project and the contribution are public and that a record
of the contribution (including all personal information I submit
with it, including my sign-off) is maintained indefinitely and may
be redistributed consistent with this project or the open source
license indicated in the file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osrf_stack_h_1.patch
Type: text/x-patch
Size: 1218 bytes
Desc: 3775413696-osrf_stack_h_1.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20080106/5a34036d/osrf_stack_h_1.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osrf_stack_c_1.patch
Type: text/x-patch
Size: 5154 bytes
Desc: 3466977960-osrf_stack_c_1.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20080106/5a34036d/osrf_stack_c_1.bin


More information about the Open-ils-dev mailing list