[OPEN-ILS-DEV] PATCH: osrf_stack.[ch] (memory leak)

[Mike Rylander]

On Jan 6, 2008 12:48 PM, Scott McKellar <mck9 at swbell.net> wrote:
> This patch plugs a minor memory leak and cleans up some miscellaneous
> things.

Applied.

>
> Summary:
>
> 1. I moved almost everything from the header into the implementation
> file, since it isn't referenced elsewhere.  All that's left is one
> prototype and some nested #includes.
>
> 2. I moved the nested #includes inside the compilation guard.
>
> 3. Except for osrf_stack_transport_handler(), all functions are now
> static.
>
> 4. I applied the const qualifier to the second parameter of
> osrf_stack_transport_handler().
>
> 5. I plugged a memory leak in osrf_stack_transport_handler().  When
> unable to open a session, we were returning without freeing the
> input message.
>
> Scott McKellar
> http://home.swbell.net/mck9/ct/
>
> Developer's Certificate of Origin 1.1 By making a contribution to
> this project, I certify that:
>
> (a) The contribution was created in whole or in part by me and I
> have the right to submit it under the open source license indicated
> in the file; or
>
> (b) The contribution is based upon previous work that, to the best
> of my knowledge, is covered under an appropriate open source license
> and I have the right under that license to submit that work with
> modifications, whether created in whole or in part by me, under the
> same open source license (unless I am permitted to submit under a
> different license), as indicated in the file; or
>
> (c) The contribution was provided directly to me by some other person
> who certified (a), (b) or (c) and I have not modified it; and
>
> (d) In the case of each of (a), (b), or (c), I understand and agree
> that this project and the contribution are public and that a record
> of the contribution (including all personal information I submit
> with it, including my sign-off) is maintained indefinitely and may
> be redistributed consistent with this project or the open source
> license indicated in the file.



-- 
Mike Rylander
 | VP, Research and Design
 | Equinox Software, Inc. / The Evergreen Experts
 | phone:  1-877-OPEN-ILS (673-6457)
 | email:  miker at esilibrary.com
 | web:  http://www.esilibrary.com