[OPEN-ILS-DEV] PATCH: osrf_message.[ch] (miscellaneous)

[Scott McKellar]

These patches are mostly a cleanup, plus some minor optimizations.

1. I replaced the deprecated identifier osrf_message with osrfMessage,
except for the typedef defining the former.

2. In the header I commented out the prototypes for
osrf_message_set_request_info() and osrf_message_to_xml(), since these
functions are nowhere defined.

3. I made sure to initialize all members of a newly allocated 
osrfMessage.

4. In osrf_message_deserialize(): I changed a series of ifs into a
series of else ifs, in order to avoid needless comparisons after one
comparison finds a match.

5. Also in osrf_message_deserialize(): I introduced a temporary
variable to cache the result of some calls to jsonObjectGetString(),
in order to avoid repeating the identical calls.

Scott McKellar
http://home.swbell.net/mck9/ct/

Developer's Certificate of Origin 1.1 By making a contribution to
this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license indicated
in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source license
and I have the right under that license to submit that work with
modifications, whether created in whole or in part by me, under the
same open source license (unless I am permitted to submit under a
different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person
who certified (a), (b) or (c) and I have not modified it; and

(d) In the case of each of (a), (b), or (c), I understand and agree
that this project and the contribution are public and that a record
of the contribution (including all personal information I submit
with it, including my sign-off) is maintained indefinitely and may
be redistributed consistent with this project or the open source
license indicated in the file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osrf_message_h_1.patch
Type: text/x-patch
Size: 3074 bytes
Desc: 1508309634-osrf_message_h_1.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20080120/c9935d0b/osrf_message_h_1.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osrf_message_c_3.patch
Type: text/x-patch
Size: 9304 bytes
Desc: 1026878722-osrf_message_c_3.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20080120/c9935d0b/osrf_message_c_3.bin