[OPEN-ILS-DEV] PATCH: osrf_message.[ch] (miscellaneous)

[Mike Rylander]

On Jan 20, 2008 4:35 PM, Scott McKellar <mck9 at swbell.net> wrote:
> These patches are mostly a cleanup, plus some minor optimizations.

Applied with thanks.

>
> 1. I replaced the deprecated identifier osrf_message with osrfMessage,
> except for the typedef defining the former.
>
> 2. In the header I commented out the prototypes for
> osrf_message_set_request_info() and osrf_message_to_xml(), since these
> functions are nowhere defined.
>
> 3. I made sure to initialize all members of a newly allocated
> osrfMessage.
>
> 4. In osrf_message_deserialize(): I changed a series of ifs into a
> series of else ifs, in order to avoid needless comparisons after one
> comparison finds a match.
>
> 5. Also in osrf_message_deserialize(): I introduced a temporary
> variable to cache the result of some calls to jsonObjectGetString(),
> in order to avoid repeating the identical calls.
>
> Scott McKellar
> http://home.swbell.net/mck9/ct/
>
> Developer's Certificate of Origin 1.1 By making a contribution to
> this project, I certify that:
>
> (a) The contribution was created in whole or in part by me and I
> have the right to submit it under the open source license indicated
> in the file; or
>
> (b) The contribution is based upon previous work that, to the best
> of my knowledge, is covered under an appropriate open source license
> and I have the right under that license to submit that work with
> modifications, whether created in whole or in part by me, under the
> same open source license (unless I am permitted to submit under a
> different license), as indicated in the file; or
>
> (c) The contribution was provided directly to me by some other person
> who certified (a), (b) or (c) and I have not modified it; and
>
> (d) In the case of each of (a), (b), or (c), I understand and agree
> that this project and the contribution are public and that a record
> of the contribution (including all personal information I submit
> with it, including my sign-off) is maintained indefinitely and may
> be redistributed consistent with this project or the open source
> license indicated in the file.
>



-- 
Mike Rylander
 | VP, Research and Design
 | Equinox Software, Inc. / The Evergreen Experts
 | phone:  1-877-OPEN-ILS (673-6457)
 | email:  miker at esilibrary.com
 | web:  http://www.esilibrary.com