[OPEN-ILS-DEV] PATCH: osrf_json_parser.c (memory leak when handling error)

[Mike Rylander]

And away we go!

On Thu, Jan 31, 2008 at 11:04 PM, Scott McKellar <mck9 at swbell.net> wrote:
> --- Bill Erickson <erickson at esilibrary.com> wrote:
>
>  > Yep, that's old debugging code.  The switch in
>  > _jsonInsertParserItem()
>  > should probably be changed to an if/else (
>  > JSON_HASH vs. JSON_ARRAY).  There's no other way to reach that chunk
>  > of
>  > code.
>
>  I believe this patch does what you suggest.

Applied.

>
>  In _jsonInsertParserItem() I changed a switch/case to an if/else,
>  eliminating a supposedly unreachable default branch that, if reached,
>  would leak memory.
>
>  With this change, a jsonObject that is neither a JSON_HASH nor a
>  JSON_ARRAY will be silently converted to a JSON_ARRAY by the call to
>  jsonObjectPush().
>
>  Scott McKellar
>  http://home.swbell.net/mck9/ct/
>
>  Developer's Certificate of Origin 1.1 By making a contribution to
>  this project, I certify that:
>
>  (a) The contribution was created in whole or in part by me and I
>  have the right to submit it under the open source license indicated
>  in the file; or
>
>  (b) The contribution is based upon previous work that, to the best
>  of my knowledge, is covered under an appropriate open source license
>  and I have the right under that license to submit that work with
>  modifications, whether created in whole or in part by me, under the
>  same open source license (unless I am permitted to submit under a
>  different license), as indicated in the file; or
>
>  (c) The contribution was provided directly to me by some other person
>  who certified (a), (b) or (c) and I have not modified it; and
>
>  (d) In the case of each of (a), (b), or (c), I understand and agree
>  that this project and the contribution are public and that a record
>  of the contribution (including all personal information I submit
>  with it, including my sign-off) is maintained indefinitely and may
>  be redistributed consistent with this project or the open source
>  license indicated in the file.



-- 
Mike Rylander
 | VP, Research and Design
 | Equinox Software, Inc. / The Evergreen Experts
 | phone:  1-877-OPEN-ILS (673-6457)
 | email:  miker at esilibrary.com
 | web:  http://www.esilibrary.com