[OPEN-ILS-DEV] PATCH: osrf_cache.c (memory leak)

Mike Rylander mrylander at gmail.com
Sun Mar 9 22:59:54 EDT 2008


On Sat, Feb 2, 2008 at 1:47 PM, Scott McKellar <mck9 at swbell.net> wrote:
> This patch plugs a memory leak and tweaks a couple of minor things.

Applied.

>
>  1. In osrfCacheGetObject() I added the const qualifier to the "data"
>  variable, since we don't write through that pointer.
>
>  2. In osrfCacheGetString() I corrected an error message that claimed
>  to be coming from a different function.
>
>  3. In osrfCacheSetExpire() we were leaking a jsonObject allocated by
>  osrfCacheGetObject().  I contrived to free it.
>
>  Scott McKellar
>  http://home.swbell.net/mck9/ct/
>
>  Developer's Certificate of Origin 1.1 By making a contribution to
>  this project, I certify that:
>
>  (a) The contribution was created in whole or in part by me and I
>  have the right to submit it under the open source license indicated
>  in the file; or
>
>  (b) The contribution is based upon previous work that, to the best
>  of my knowledge, is covered under an appropriate open source license
>  and I have the right under that license to submit that work with
>  modifications, whether created in whole or in part by me, under the
>  same open source license (unless I am permitted to submit under a
>  different license), as indicated in the file; or
>
>  (c) The contribution was provided directly to me by some other person
>  who certified (a), (b) or (c) and I have not modified it; and
>
>  (d) In the case of each of (a), (b), or (c), I understand and agree
>  that this project and the contribution are public and that a record
>  of the contribution (including all personal information I submit
>  with it, including my sign-off) is maintained indefinitely and may
>  be redistributed consistent with this project or the open source
>  license indicated in the file.



-- 
Mike Rylander
 | VP, Research and Design
 | Equinox Software, Inc. / The Evergreen Experts
 | phone:  1-877-OPEN-ILS (673-6457)
 | email:  miker at esilibrary.com
 | web:  http://www.esilibrary.com


More information about the Open-ils-dev mailing list