[OPEN-ILS-DEV] PATCH: osrf_transgroup.c (initializing buffers)

Scott McKellar mck9 at swbell.net
Tue Mar 11 23:01:35 EDT 2008


This patch elinminates the use of the osrf_clearbuf macro in several
spots.  In each case, the buffer needs to be initialized to an empty
string, because the call to jid_get_* doesn't necessarily populate it
with anything else.  In debugging mode, osrf_clearbuf() will fill the
field with exclamation points, which is not helpful in this context.

Probably the jid_get_* routines should render the output string
empty if they can't find what they're looking for.  However that's a
patch for another day.

Scott McKellar
http://home.swbell.net/mck9/ct/

Developer's Certificate of Origin 1.1 By making a contribution to
this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license indicated
in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source license
and I have the right under that license to submit that work with
modifications, whether created in whole or in part by me, under the
same open source license (unless I am permitted to submit under a
different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person
who certified (a), (b) or (c) and I have not modified it; and

(d) In the case of each of (a), (b), or (c), I understand and agree
that this project and the contribution are public and that a record
of the contribution (including all personal information I submit
with it, including my sign-off) is maintained indefinitely and may
be redistributed consistent with this project or the open source
license indicated in the file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osrf_transgroup_c_1.patch
Type: text/x-patch
Size: 1504 bytes
Desc: 442357485-osrf_transgroup_c_1.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20080311/87b3cbb7/osrf_transgroup_c_1.bin


More information about the Open-ils-dev mailing list