[OPEN-ILS-DEV] PATCH: WWW/SuperCat.pm

Sun Nov 16 11:08:35 EST 2008

I am stuck in a maze of stacks, all alike, with only my handy PDA to  
guide me. Currently, if I do that, the slimpac just reminds me where I  
am (in a maze of stacks).

I have submitted two patches. The first, 'SuperCat.pm.patch.help',  
will let me use the slimpac (which works better on my PDA) to find  
helpful materials (to solve any problem, not just this maze one) by  
searching for the keyword 'help' under any index. The second,  
'SuperCat.pm.patch.whereami' does the same as the first, but will also  
will helpfully remind me where I am if I ask the slimpac the slightly  
more specific question, 'whereami'.

It goes without saying that only one of these patches ought to be applied.

Neither of these probably requires a DCO, but here one is anyway.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
     have the right to submit it under the open source license
     indicated in the file; or

(b) The contribution is based upon previous work that, to the best
     of my knowledge, is covered under an appropriate open source
     license and I have the right under that license to submit that
     work with modifications, whether created in whole or in part
     by me, under the same open source license (unless I am
     permitted to submit under a different license), as indicated
     in the file; or

(c) The contribution was provided directly to me by some other
     person who certified (a), (b) or (c) and I have not modified
     it.

(d) I understand and agree that this project and the contribution
     are public and that a record of the contribution (including all
     personal information I submit with it, including my sign-off) is
     maintained indefinitely and may be redistributed consistent with
     this project or the open source license(s) involved.

Signed-off-by: Brandon Uhlman (brandon.uhlman at gov.bc.ca)



======================================
Brandon W. Uhlman, Systems Consultant
Public Library Services Branch
British Columbia Ministry of Education
Vancouver, BC (and Lillooet, BC)

Phone: (604) 660-2972 or (250) 256-0344
E-mail: brandon.uhlman at gov.bc.ca
         brandon.uhlman at bclibrary.ca

-------------- next part --------------
Index: Open-ILS/src/perlmods/OpenILS/WWW/SuperCat.pm
===================================================================

--- Open-ILS/src/perlmods/OpenILS/WWW/SuperCat.pm	(revision 11222)
+++ Open-ILS/src/perlmods/OpenILS/WWW/SuperCat.pm	(working copy)
@@ -1040,21 +1040,6 @@
 	}
 	my $flesh_feed = ($type =~ /-full$/o) ? 1 : 0;
 
-	if ($terms eq 'help') {
-		print $cgi->header(-type => 'text/html');
-		print <<"		HTML";
-			<html>
-			 <head>
-			  <title>just type something!</title>
-			 </head>
-			 <body>
-			  <p>You are in a maze of dark, twisty stacks, all alike.</p>
-			 </body>
-			</html>
-		HTML
-		return Apache2::Const::OK;
-    }
-	
 	$terms = decode_utf8($terms);
 	$lang = 'eng' if ($lang eq 'en-US');
 
-------------- next part --------------
Index: src/perlmods/OpenILS/WWW/SuperCat.pm
===================================================================
--- src/perlmods/OpenILS/WWW/SuperCat.pm	(revision 11222)
+++ src/perlmods/OpenILS/WWW/SuperCat.pm	(working copy)
@@ -1040,12 +1040,12 @@
 	}
 	my $flesh_feed = ($type =~ /-full$/o) ? 1 : 0;
 
-	if ($terms eq 'help') {
+	if ($terms eq 'whereami') {
 		print $cgi->header(-type => 'text/html');
 		print <<"		HTML";
 			<html>
 			 <head>
-			  <title>just type something!</title>
+			  <title>(X) YOU ARE HERE.</title>
 			 </head>
 			 <body>
 			  <p>You are in a maze of dark, twisty stacks, all alike.</p>
