[OPEN-ILS-DEV] PATCH: reports - first5 transform typo, template save success

[Jeff Godin]

Greetings-

Another minor patch, attached.

The "First 5 characters" transform appears to be broken due to a typo,
patch attached. To fix previously broken templates created using this
transform, clone, re-select the First 5 characters transform on any fields
where you were using it, and save the template.

Also in this patch, change from confirm() to alert() for "Template NAME
was successfully saved." No point in using confirm(), nothing was checking
the return value, etc.

Changes tested on 1.4.0.2, patch is against trunk.

For your consideration,

-jeff


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Jeff Godin <jeff at tcnet.org>
-------------- next part --------------
Index: Open-ILS/web/reports/xul/template-config.js
===================================================================
--- Open-ILS/web/reports/xul/template-config.js	(revision 12435)
+++ Open-ILS/web/reports/xul/template-config.js	(working copy)
@@ -804,7 +804,7 @@
 				alertILSEvent(res);
 			} else {
 				if( res && res != '0' ) {
-					confirm(dojo.string.substitute( rpt_strings.TEMPLATE_CONF_SUCCESS_SAVE, [tmpl.name()] ));
+					alert(dojo.string.substitute( rpt_strings.TEMPLATE_CONF_SUCCESS_SAVE, [tmpl.name()] ));
 					_l('../oils_rpt.xhtml');
 				}
 			}
Index: Open-ILS/web/reports/xul/transforms.js
===================================================================
--- Open-ILS/web/reports/xul/transforms.js	(revision 12435)
+++ Open-ILS/web/reports/xul/transforms.js	(working copy)
@@ -91,7 +91,7 @@
 		label : rpt_strings.TRANSFORMS_UPPER
 	},
 
-	firt5 : {
+	first5 : {
 		datatype : [ OILS_RPT_DTYPE_STRING ],
 		label : rpt_strings.TRANSFORMS_FIRST5
 	},