[OPEN-ILS-DEV] MFHD Contribution - Non-whitespace Patches

[Dan Wells]

Hello,

Here is the actual set of patches to be applied after the whitespace patches.  They have been thoroughly tested using the provided testing facilities and some additional tests of my own.  The following summarizes this patch set:

CHANGES
. Added support for compressed 863 holdings, including both structure and function
. Added function to turn 863 chronologies into ISO datestrings (YYYY-MM-DD)
. Employed the existing prediction logic to generate full prediction lists by way of an 863 increment method
. Added necessary accessor and setter methods to reduce direct object attribute access
. Renamed a few methods to better fit the expanded object interfaces
. Cleaned up a few commented-out print-type debug statements
. Other minor changes

TODO
. Switch to full POD-style inline documentation
. Address various XXX and TODO comments here and there as needed
. Further flesh out object interfaces as needed

Special thanks to David Fiander for handling the hard work of accommodating the MFHD pattern standard.

Please let me know if you have any questions about anything contained here.

Thanks,
Dan

================================================
Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Dan Wells <dbw2 at calvin.edu>


>>> On 11/13/2009 at 10:17 AM, David Fiander <david at fiander.info> wrote:
> Thanks for this Dan. I'll get to it today or tomorrow.
> 
> - David
> 
> On Thu, Nov 12, 2009 at 4:47 PM, Dan Wells <dbw2 at calvin.edu> wrote:
>> Hello all,
>>
>> Sometime later today or tomorrow I intend to submit a fairly extensive patch 
> which adds new functionality to the MFHD components in EG.  In preparation of 
> that, attached are some whitespace-only patches of the files involved.  The 
> files in question were run through 'perltidy -ce' as described in the 
> preliminary code standards document here:
>>
>> http://www.open-ils.org/dokuwiki/doku.php?id=code_formatting_standards 
>>
>> Please reply when these get applied, if possible.
>>
>> Thanks!
>>
>> Dan
>>
>> --
>>
>> 
> *****************************************************************************
> ****
>> Daniel Wells, Library Programmer Analyst dbw2 at calvin.edu 
>> Hekman Library at Calvin College
>> 616.526.7133
>>
>>
>>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: MFHD_updates.tar.gz
Type: application/x-gzip
Size: 9154 bytes
Desc: not available
Url : http://libmail.georgialibraries.org/pipermail/open-ils-dev/attachments/20091113/dda2b78f/attachment.bin