[OPEN-ILS-DEV] Whitespace, copyright

[Nathan Eady]

Dan Scott <dan at coffeecode.net> writes:

>> > white space changes committed separately from code changes,
>> 
>> That's how I've been trying to do it, but of course, if I change
>> whitespace by accident, I'm too lazy to try to work it out of my
>> commit. :)
>
> Right, I've certainly been guilty in the past too. But then, we've
> never really talked about it so anything was fair game :) So we
> could agree to try to keep whitespace changes (say, more than a
> couple of contiguous lines) separate from code changes...

IMO, having a commit that's mostly code changes and incidentally also
removes a small bit of trailing whitespace here or there is one thing,
and having a commit that's mostly whitespace fixup but also includes
some significant code changes is something else.  The former seems
normal and fine to me; whereas, the latter seems suboptimal.

Just my two cents.

-- 
Nathan Eady
Galion Public Library