[OPEN-ILS-DEV] ***SPAM*** Patch for trunk (simpler prevention of Mark Claimed Returned date format error bug)

Mike Rylander mrylander at gmail.com
Tue Jul 20 15:55:18 EDT 2010


This has been applied to trunk, moving on to the other version.

Thanks, John!

--miker

On Mon, Jul 12, 2010 at 3:07 PM, John Craig
<jc-mailinglist at alphagconsulting.com> wrote:
> Index: Circ.pm
> ===================================================================
> --- Circ.pm     (revision 16912)
> +++ Circ.pm     (working copy)
> @@ -373,10 +373,8 @@
>          my $original_date =
> DateTime::Format::ISO8601->new->parse_datetime(cleanse_ISO8601($circ->due_date));
>          my $new_date =
> DateTime::Format::ISO8601->new->parse_datetime($backdate);
>          $backdate = $new_date->ymd . 'T' .
> $original_date->strftime('%T%z');
> -        if ($backdate =~
> /^(\d\d\d\d-\d\d-\d\dT\d\d:\d\d:\d\d-\d\d)(\d\d)$/) {
> -            $backdate = "$1:$2"; # put a colon in the timestamp component
> for DateTime::Format::ISO8601->parse_datetime
> -        }
> -
> +       # clean it up once again; need a : in the timezone offset. E.g.
> -06:00 not -0600
> +       $backdate = cleanse_ISO8601($backdate);
>          # make it look like the circ stopped at the cliams returned time
>          $circ->stop_fines_time($backdate);
>          my $evt = OpenILS::Application::Circ::CircCommon->void_overdues($e,
> $circ, $backdate);
>
>
> Developer's Certificate of Origin 1.1
>
> By making a contribution to this project, I certify that:
>
> (a) The contribution was created in whole or in part by me and I
>     have the right to submit it under the open source license
>     indicated in the file; or
>
> (b) The contribution is based upon previous work that, to the best
>     of my knowledge, is covered under an appropriate open source
>     license and I have the right under that license to submit that
>     work with modifications, whether created in whole or in part
>     by me, under the same open source license (unless I am
>     permitted to submit under a different license), as indicated
>     in the file; or
>
> (c) The contribution was provided directly to me by some other
>     person who certified (a), (b) or (c) and I have not modified
>     it.
>
> (d) I understand and agree that this project and the contribution
>     are public and that a record of the contribution (including all
>     personal information I submit with it, including my sign-off) is
>     maintained indefinitely and may be redistributed consistent with
>     this project or the open source license(s) involved.
>
> Signed-off-by:
> John M. Craig
> jc-mailinglist at alphagconsulting.com
>
>
>



-- 
Mike Rylander
 | VP, Research and Design
 | Equinox Software, Inc. / The Evergreen Experts
 | phone:  1-877-OPEN-ILS (673-6457)
 | email:  miker at esilibrary.com
 | web:  http://www.esilibrary.com


More information about the Open-ils-dev mailing list