[OPEN-ILS-DEV] ***SPAM*** Overhaul of serial schema

[Mike Rylander]

I don't have any objection to this.  Dan, do you want to send an IDL patch
with your preferred names for the serial-schema fieldmapper classes?

One caution I would offer is to avoid using variables with the same name as
a class.  Particularly in JS, this can lead to unintended squashing of the
class definition since a "class" is just a constructor function, which is
just a (usually) global variable itself.

--miker

On Jun 2, 2010 5:42 PM, "Dan Wells" <dbw2 at calvin.edu> wrote:

Hello Scott,

Thanks for moving this forward.  I have just one small concern (which I will
immediately drop if I am alone in thinking this).  IMHO, the IDL class ids
are a bit on the short side.  For instance, in my development code (which I
*really* expect to get out there soon now that things have finally settled a
bit more) I used the id 'sdist' rather simply 'sd' for serial.distribution.
 It is such a handy nickname, I use it not just where it needs to be used
but also in variable names and whatnot, so general uniqueness becomes really
important.  I think 3 characters can work if the particular assortment is
not a common one in English (e.g. 'acn'), but otherwise 4 or 5 character ids
can really improve readability/debugability/searchability.

Again, just IMHO.

Thanks again,
Dan


>>> On 6/2/2010 at 3:39 PM, Scott McKellar <mck9 at swbell.net> wrote:
> I just committed a large patc...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://libmail.georgialibraries.org/pipermail/open-ils-dev/attachments/20100602/d81c0fa4/attachment.htm