[OPEN-ILS-DEV] ***SPAM*** Overhaul of serial schema

[Dan Wells]

Hello Scott,

Thanks for moving this forward.  I have just one small concern (which I will immediately drop if I am alone in thinking this).  IMHO, the IDL class ids are a bit on the short side.  For instance, in my development code (which I *really* expect to get out there soon now that things have finally settled a bit more) I used the id 'sdist' rather simply 'sd' for serial.distribution.  It is such a handy nickname, I use it not just where it needs to be used but also in variable names and whatnot, so general uniqueness becomes really important.  I think 3 characters can work if the particular assortment is not a common one in English (e.g. 'acn'), but otherwise 4 or 5 character ids can really improve readability/debugability/searchability.

Again, just IMHO.

Thanks again,
Dan

>>> On 6/2/2010 at 3:39 PM, Scott McKellar <mck9 at swbell.net> wrote:
> I just committed a large patch in trunk to gut the serial schema and replace 
> it with a different set of tables, along the lines of my posting on May 17.
> 
> This patch does *not* include the serial.caption_and_pattern table that was 
> proposed  in the meanwhile.  I will add that table later in a separate post. 
> I just didn't want the rest to have to wait for it.
> 
> Any patch of this size is likely to include at least a few typos, 
> oversights, and blunders.  In particular it's hard to be sure that the 
> upgrade script will apply cleanly, because I had been tinkering with the 
> serial schema in my own sandbox.  It may take a few more commits to correct 
> any such errors.
> 
> Scott McKellar