[OPEN-ILS-DEV] branch rel_1_6 950.data.seed-values.sql ordering bug

[Don McMorris]

In the branch rel_1_6 version of 950.data.seed-values.sql [1], lines
138-142 create the OU setting
'circ.booking_reservation.default_elbow_room' via the query:

INSERT INTO actor.org_unit_setting (org_unit, name, value) VALUES (
           (SELECT id FROM actor.org_unit WHERE parent_ou IS NULL),
           'circ.booking_reservation.default_elbow_room',
           '"1 day"'
       );

However, it appears that actor.org_unit does not start to get
populated until line 853.  As such, the "SELECT id FROM actor.org_unit
WHERE parent_ou IS NULL" portion of the insert will return NULL, and
actor.org_unit_setting.org_unit has a 'NOT NULL' contraint - as such,
the insert fails.

The attached patch moves this chunk down to after the actor.org_unit
and actor.org_address work, but before the config.* work.

This bug also exists in branch rel_1_6_1 and tags rel_1_6_1_0 &
rel_1_6_1_1.  It does not appear to affect branch rel_1_6_0 or any
tags of rel_1_6_0_x.  It also does not appear to affect trunk (I
cannot find the string "booking_reservation" in the
950.data.seed-values.sql in trunk).

I've worked around the issue (in a 1.6.1.1 install I'm attempting) by
simply running the affected chunk by hand after the rest of the
seeding completes.

Thanks!
--Don

[1]: http://svn.open-ils.org/trac/ILS/browser/branches/rel_1_6/Open-ILS/src/sql/Pg/950.data.seed-values.sql
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 950.data.seed-values.sql.patch
Type: text/x-patch
Size: 1922 bytes
Desc: not available
Url : http://libmail.georgialibraries.org/pipermail/open-ils-dev/attachments/20100628/9f60c571/attachment.bin