[OPEN-ILS-DEV] Toolbar Buttons in New Tab Option

[Thomas Berezansky]

The setting in prefs.js was intentionally set to false to keep the  
current action of same tab by default. I put it there so that the  
about:config editor can be more easily used to change it to true.

I did limited testing, but don't see why the cmd_patron_search button  
would do different things at different times without the setting  
changed, although this patch did not touch things when you use the  
menu or hotkeys, only when you use the actual toolbar buttons.

Thomas Berezansky
Merrimack Valley Library Consortium


Quoting Ben Shum <bshum at biblio.org>:

>  Hi Thomas,
>
> Wow, very cool stuff.  I applied it by hand to one of my Linux staff
> client folders for EG 1.6.0.2 and it seemed to work quite well.
>
> From the patch though, the setting in prefs.js was shown to be:
>
> pref("open-ils.toolbar.defaultnewtab", false);
>
> I had to set this to "true" in order to have the toolbar button open a
> new tab instead of the current tab.  With this set to "false", this
> behavior only occurred when holding down the CTRL key for the opposite.
>
> Also, I noted that the behavior for the cmd_patron_search key was a bit
> off where it wouldn't always adhere to the new tab function and replaced
> the existing tab's contents instead when calling it up.  Might be
> conflicts between 1.6 vs. trunk or my poor attempts at adapting it.
> Will poke around a bit more.
>
> All around quite promising though!  Thanks for sharing!
>
> -- Ben
>
> On 10/20/2010 04:33 PM, Thomas Berezansky wrote:
>> The attached patch to trunk adds the ability to set an
>> open-ils.toolbar.defaultnewtab preference to cause the toolbar buttons
>> to open in a new tab instead of the current tab. Holding the "accel"
>> key (default of ctrl on windows/linux and command on mac) will do the
>> opposite.
>>
>> I only applied this to the five commands currently in use on the
>> toolbar for now. Any other commands added to the toolbar will need to
>> have their command handlers in menu.js updated.
>>
>> Thomas Berezansky
>> Merrimack Valley Library Consortium
>>
>>
>>
>>
>