[OPEN-ILS-DEV] More unicode patches for SIPServer

[Joe Atzberger]

>
> Your commit message mentions that the testcases appear to be invalid and
> that
> they came from some "guide"; I don't see any samples in the SIP2
> Protocol Definition so I guess that's some other resource?


Yeah, I think it was called the SIP Implementer's Handbook.  Among other
things it gave a nice detailed step-by-step computation of checksums... for
a trivial example... on a system with several loaded assumptions.  For
almost every other request/response, it included these problematic checksums
I could not reproduce.  I suspect the example lines were adjusted (e.g. to
change the username/password) and the checksums were not updated.  And this
was supposed to be my guide *out* of the mess.



> they should absolutely be removed from the unit tests
> and replaced with actual examples from the wild - ideally identifying
> what make and model of self-check or SIP client the examples came from.
>

Indeed.


> It's not clear to me what you're suggesting then. [...]

I can add unit tests that match our environment


That is pretty much exactly what I'm asking for.  I don't mind breaking
hypothetical systems in the wild if we can at least ask them "what values
are you getting for the tests that compute OK on ours?  And what does the
*extensive* debugging output look like?"

Thanks for the reply and persistence.
--joe
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://libmail.georgialibraries.org/pipermail/open-ils-dev/attachments/20110622/315f7605/attachment.htm>