[OPEN-ILS-DEV] Diacriticals IISH sources

[Joscha Filius]

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Joscha Filius eaglegrip at gmail.com


On Thu, May 5, 2011 at 6:02 PM, Lebbeous Fogle-Weekley <
lebbeous at esilibrary.com> wrote:

> Joscha,
>
> Thanks again for your work on this feature. Can you help with one quick
> thing?  We'd like a DCO.  What's a DCO?  Read on.
>
> I'd like to get this into the 2.1 beta process (up against a deadline) so
> the community can test it and offer feedback.
>
> Would you see the bottom of this page:
> http://open-ils.org/dokuwiki/doku.php?id=contributing
>
> and copy the Developer's Certificate of Origin at the bottom, with your
> name in the last line, and reply to this message on the mailing list? This
> is just a way of formally donating the code to the project.
>
> Thanks,
>
> Lebbeous!
>
>
> On 04/28/2011 06:33 AM, Joscha Filius wrote:
>
>> In the attachment there is a .diff file containing patches with changes
>> made
>> to a version of release 2.0.3 running on a server at IISH. I've tried to
>> select the changes and files that are relevant to a diacritical insert
>> overlay. (I hope I have not forgot anything)
>>
>> *What does it do?*
>> It adds a menu in the marc editor. The menu consists of a pallet of
>> diacritics which users can change by right clicking and selecting another
>> diacritic from a menu. Once selected the diacritic appears on the palette
>> and when they insert it by selecting it on the palette the value of the
>> menu
>> button is persisted.
>>
>> *The files consists of:*
>> a javascript file that adds a listener to ctrl-s that opens up a menu in
>> marcedit fields and some code to insert selected diacriticals.
>>  and a xul file containing the menu structure and also all diacriticals
>> codes. Strings still need to be externalised for internationalisation etc.
>>
>> *Bugs:*
>> A known bug is that is you switch marc edit styles back and forth the
>> listener trigger won't work anymore. Also for a far as I know there is at
>> least another bug concerning layout which is as far as I know not the
>> result
>> of my doing.
>>
>> *Here comes a possibly nasty part*, to ensure that the diacriticals remain
>> intact throughout the persist I've changed global_util.js to URL encode
>> and
>> URL decode all stored values. This might cause backwards incompatibility
>> with values that are already stored for other purposes without encoding.
>> This needs to be checked.
>>
>> kind regards,
>> Joscha Filius
>>
>> PS.
>> There are some other changes I've implemented for IISH that you might want
>> to implement
>> Like minor bug fixes and making the new marc template selection for
>> cataloging sticky.
>>
>>
>
> --
> Lebbeous
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://libmail.georgialibraries.org/pipermail/open-ils-dev/attachments/20110506/3ab00b2c/attachment-0001.htm