[OPEN-ILS-DEV] OpenSRF - C Unit Testing

[Dan Scott]

Merged to trunk and the rel_2 branch. Thanks Kevin!

On Wed, Apr 27, 2011 at 1:08 PM, Kevin Beswick <kevinbeswick00 at gmail.com> wrote:
> Dan, Bill,
>
> Thanks for the feedback, here is an updated version of the patch with
> Dan's changes. The branch that I have been using to track these C unit
> testing efforts is at:
> https://github.com/kbeswick/opensrf/tree/unit_testing
>
> As for the DCO (my name is also on the standing DCO section of the wiki):
>
> Developer's Certificate of Origin 1.1
>
> By making a contribution to this project, I certify that:
>
> (a) The contribution was created in whole or in part by me and I
>    have the right to submit it under the open source license
>    indicated in the file; or
>
> (b) The contribution is based upon previous work that, to the best
>    of my knowledge, is covered under an appropriate open source
>    license and I have the right under that license to submit that
>    work with modifications, whether created in whole or in part
>    by me, under the same open source license (unless I am
>    permitted to submit under a different license), as indicated
>    in the file; or
>
> (c) The contribution was provided directly to me by some other
>    person who certified (a), (b) or (c) and I have not modified
>    it.
>
> (d) I understand and agree that this project and the contribution
>    are public and that a record of the contribution (including all
>    personal information I submit with it, including my sign-off) is
>    maintained indefinitely and may be redistributed consistent with
>    this project or the open source license(s) involved.
>
> Signed-off-by: Kevin Beswick <kevinbeswick00 at gmail.com>
>
> On Sun, Apr 24, 2011 at 10:33 PM, Dan Scott <dan at coffeecode.net> wrote:
>> On 11 April 2011 12:10, Kevin Beswick <kevinbeswick00 at gmail.com> wrote:
>>> Hello,
>>>
>>> Attached is a patch which puts a C unit testing framework in place for
>>> OpenSRF, as well as a bunch of tests for libopensrf. The unit testing
>>> framework is called "Check" - http://check.sourceforge.net/
>>
>> This is great, Kevin!
>>
>> Minor nit: rather than "PKG_CHECK_MODULES([CHECK]..." in configure.ac,
>> use "PKG_CHECK_MODULES([Check]..." so that in config.log the output
>> will show "checking for Check" (the actual package name) instead of
>> "checking for CHECK". (Side effect: CHECK_CFLAGS / CHECK_LIBS needs to
>> be changed to Check_CFLAGS / Check_LIBS respectively).
>>
>>> These tests can be executed by running 'make check' after you
>>> configure and compile the OpenSRF code.
>>
>> Tested and works on Fedora 14. Nice!
>>
>>> To run them, you must have the 'check' package installed. I have added
>>> an entry for Debian based OSes into Makefile.install, and would
>>> appreciate if anyone running other distros can add the appropriate
>>> entries for those as well.
>>
>> For Fedora, one needs to install the "check" and "check-devel"
>> packages. Is this code in a DVCS branch somewhere so that we can fork
>> and ask you to pull minor enhancements like that?
>>
>>> For more information on the framework, check out the Check manual at
>>> http://check.sourceforge.net/doc/check_html/index.html. Also I will
>>> soon create a Unit Testing area on the wiki with info about unit
>>> testing in Evergreen/OpenSRF.
>>
>> We will need a DCO for this
>> (http://evergreen-ils.org/dokuwiki/doku.php?id=contributing#developer_s_certificate_of_origin),
>> but I think it's very close to being able to be merged.
>>
>