[OpenSRF-GIT] OpenSRF branch master updated. d390d1ae315bd9c9326c9ef76ebf74f57ddaa573

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "OpenSRF".

The branch, master has been updated
       via  d390d1ae315bd9c9326c9ef76ebf74f57ddaa573 (commit)
      from  c0630d2bcedb086ac4e8bef98cc37748fc0cce3a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d390d1ae315bd9c9326c9ef76ebf74f57ddaa573
Author: Bill Erickson <berick at esilibrary.com>
Date:   Tue Jun 26 09:21:57 2012 -0400

    Prevent "uninitialized value" warnings in parameter logging
    
    Use of uninitialized value $p[0] in join or string at
    /usr/local/share/perl/5.10.1/OpenSRF/Application.pm line 130.
    
    This is caused when the array of method params contains null/undef
    values.  Prevent the warnings by replacing these values w/ empty
    strings.
    
    Signed-off-by: Bill Erickson <berick at esilibrary.com>
    Signed-off-by: Dan Scott <dscott at laurentian.ca>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

diff --git a/src/perl/lib/OpenSRF/Application.pm b/src/perl/lib/OpenSRF/Application.pm
index 9283b7f..0a5c188 100644
--- a/src/perl/lib/OpenSRF/Application.pm
+++ b/src/perl/lib/OpenSRF/Application.pm
@@ -146,7 +146,7 @@ sub handler {
 			if ($redact_params) {
 				$logdata .= "**PARAMS REDACTED**";
 			} else {
-				$logdata .= join(', ', at p);
+				$logdata .= join(', ', map { (defined $_) ? $_ : '' } @p);
 			}
 		}
 		$log->info($logdata);

-----------------------------------------------------------------------

Summary of changes:
 src/perl/lib/OpenSRF/Application.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
OpenSRF